Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libosmocore: 1.2.0 -> 1.6.0 #170175

Merged
merged 1 commit into from
May 4, 2022
Merged

libosmocore: 1.2.0 -> 1.6.0 #170175

merged 1 commit into from
May 4, 2022

Conversation

armeenm
Copy link
Contributor

@armeenm armeenm commented Apr 25, 2022

Description of changes

https://github.com/osmocom/libosmocore/tags
As a bonus, this also trades python2 for python3 (#148779).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from mogorman April 25, 2022 02:04
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 25, 2022
@Mindavi
Copy link
Contributor

Mindavi commented Apr 25, 2022

Result of nixpkgs-review pr 170175 run on x86_64-linux 1

1 package failed to build:
  • libosmocore

error: Function called without required argument "libusb" at /home/rick/.cache/nixpkgs-review/pr-170175/nixpkgs/pkgs/applications/misc/libosmocore/default.nix:6, did you mean "librsb", "libusb1" or "ibus"?
(use '--show-trace' to show detailed location information)

Copy link
Contributor

@Mindavi Mindavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change libusb to libusb1?

@armeenm
Copy link
Contributor Author

armeenm commented Apr 25, 2022

Oh, weird; how does this build for me? Anyways, should be fixed now.

@Mindavi
Copy link
Contributor

Mindavi commented Apr 25, 2022

Result of nixpkgs-review pr 170175 run on x86_64-linux 1

1 package built:
  • libosmocore

Cross-compiles (aarch64) as well, good to go!

Copy link
Contributor

@Mindavi Mindavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give the maintainer some time to respond as well btw.

@Artturin Artturin added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 4, 2022
@Mindavi Mindavi merged commit eb4cc64 into NixOS:master May 4, 2022
@armeenm armeenm deleted the bump-libosmocore branch May 4, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants