Skip to content

ebpf-exporter: init at 2.4.2 and add module#301253

Merged
marcusramberg merged 2 commits intoNixOS:masterfrom
jpds:ebpf-exporter-2.4.0
Apr 29, 2025
Merged

ebpf-exporter: init at 2.4.2 and add module#301253
marcusramberg merged 2 commits intoNixOS:masterfrom
jpds:ebpf-exporter-2.4.0

Conversation

@jpds
Copy link
Contributor

@jpds jpds commented Apr 3, 2024 •
edited
Loading

Description of changes

Adds https://github.com/cloudflare/ebpf_exporter at 2.4.1, tested with biolatency eBPF program from upstream.

Also adds a module for the exporter.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 3, 2024
@Sigmanificient
Copy link
Member

Sigmanificient commented Apr 3, 2024

Result of nixpkgs-review pr 301253 run on x86_64-linux 1

Sigmanificient
Sigmanificient previously requested changes Apr 3, 2024
View reviewed changes
@jpds jpds force-pushed the ebpf-exporter-2.4.0 branch 4 times, most recently from 0d9f010 to 39d9b8a Compare April 3, 2024 18:27
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 3, 2024
@Ma27
Copy link
Member

Ma27 commented Apr 7, 2024

A module (and ideally a test) for that would be nice.

@jpds jpds force-pushed the ebpf-exporter-2.4.0 branch from 39d9b8a to 245650a Compare May 14, 2024 20:27
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label May 14, 2024
@jpds jpds force-pushed the ebpf-exporter-2.4.0 branch from 245650a to 74cea77 Compare May 14, 2024 20:30
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 14, 2024
@jpds jpds force-pushed the ebpf-exporter-2.4.0 branch from 3de7b69 to edfc840 Compare May 14, 2024 21:06
@jpds jpds changed the title ebpf-exporter: init at 2.4.0 ebpf-exporter: init at 2.4.1 and add module May 14, 2024
@jpds jpds force-pushed the ebpf-exporter-2.4.0 branch 3 times, most recently from 5ee60c0 to d4b2e0d Compare May 14, 2024 21:26
@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes labels May 14, 2024
@ofborg ofborg bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label May 14, 2024
@jpds
Copy link
Contributor Author

jpds commented May 14, 2024

@Ma27 Should be good to go now.

@jpds jpds force-pushed the ebpf-exporter-2.4.0 branch 2 times, most recently from 4b1b145 to 3162f60 Compare May 19, 2024 11:40
@jpds
Copy link
Contributor Author

jpds commented Mar 26, 2025

Ready to go now.

@jpds jpds force-pushed the ebpf-exporter-2.4.0 branch from ba31409 to a57b257 Compare March 26, 2025 11:23
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@LostAttractor
Copy link
Member

LostAttractor commented Apr 9, 2025 •
edited
Loading

LTGM. Please rebase to master.

@jpds jpds force-pushed the ebpf-exporter-2.4.0 branch from a57b257 to 5ef1e9d Compare April 11, 2025 19:48
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 11, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 14, 2025
Bot-wxt1221
Bot-wxt1221 reviewed Apr 18, 2025
View reviewed changes
Bot-wxt1221
Bot-wxt1221 reviewed Apr 18, 2025
View reviewed changes
Bot-wxt1221
Bot-wxt1221 reviewed Apr 18, 2025
View reviewed changes
Bot-wxt1221
Bot-wxt1221 reviewed Apr 18, 2025
View reviewed changes
@Bot-wxt1221

This comment has been minimized.

Sign in to view
@jpds jpds force-pushed the ebpf-exporter-2.4.0 branch 3 times, most recently from 2104c57 to 31c6286 Compare April 19, 2025 09:36
Bot-wxt1221
Bot-wxt1221 approved these changes Apr 19, 2025
View reviewed changes
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if can be built.

@Bot-wxt1221
Copy link
Member

Bot-wxt1221 commented Apr 19, 2025

nixpkgs-reviewd workflow finished

Status and logs: https://github.com/Bot-wxt1221/nixpkgs-reviewd/actions/runs/14548603631

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 301253

x86_64-linux

⏩ 1 package blacklisted:
  • nixos-install-tools
✅ 1 package built:
  • prometheus-ebpf-exporter

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 19, 2025
@jpds jpds force-pushed the ebpf-exporter-2.4.0 branch from 31c6286 to f9aba46 Compare April 23, 2025 15:30
@jpds jpds requested a review from fpletz April 29, 2025 10:04
@marcusramberg
Copy link
Contributor

marcusramberg commented Apr 29, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 301253

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • prometheus-ebpf-exporter

@marcusramberg
Copy link
Contributor

marcusramberg commented Apr 29, 2025

Started on aarch64-linux and confirmed I could get metrics for the timers which is used as example in the module. Change lgtm.

@marcusramberg marcusramberg dismissed Sigmanificient’s stale review April 29, 2025 13:04

Requested changes have been addressed.

@marcusramberg marcusramberg merged commit 178f679 into NixOS:master Apr 29, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ma27 Ma27 Ma27 left review comments

@marcusramberg marcusramberg marcusramberg approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@Sigmanificient Sigmanificient Awaiting requested review from Sigmanificient

+2 more reviewers

@LostAttractor LostAttractor LostAttractor approved these changes

@Bot-wxt1221 Bot-wxt1221 Bot-wxt1221 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: tests This PR has tests 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jpds @Sigmanificient @Ma27 @LostAttractor @Bot-wxt1221 @marcusramberg @wegank @h7x4