volk: 3.0.0 -> 3.1.2 #330477

doronbehar · 2024-07-27T18:07:06Z

Description of changes

Things done

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/vo/volk/package.nix

tko · 2024-07-27T20:29:48Z

FWIW I built default.nix on aarch64-darwin successfully earlier, and other than some cosmetics this PR seems fine.

nixpkgs-review is taking a long while...

doronbehar · 2024-07-27T20:50:51Z

FWIW I built default.nix on aarch64-darwin successfully earlier, and other than some cosmetics this PR seems fine.

That's not the same thing - now the expression is very different - it is not even located in the same place and it, and it doesn't build the same sources.

nixpkgs-review is taking a long while...

Yea I should have recommended to you to wait a bit for ofborg to finish evaluation here so that you won't run it locally. See the ofborg (first) feature explained here. ofborg just finished evaluating attributes here, so respawning nixpkgs-review should at least start building things a bit faster. If it already builds attributes for you, there is no way to speed it up.

tko · 2024-07-28T07:05:19Z

Result of nixpkgs-review pr 330477 run on aarch64-darwin 1

1 package failed to build:

gnuradio3_8Packages.ais

20 packages built:

gnuradio
gnuradio3_8
gnuradio3_8Minimal
gnuradio3_8Packages.grnet
gnuradio3_8Packages.osmosdr
gnuradio3_8Packages.osmosdr.dev
gnuradio3_8Packages.rds
gnuradio3_9
gnuradioMinimal (gnuradio3_9Minimal)
gnuradio3_9Packages.grnet
gnuradio3_9Packages.osmosdr
gnuradio3_9Packages.osmosdr.dev
gnuradioPackages.osmosdr
gnuradioPackages.osmosdr.dev
sdrpp
sigdigger
sigutils
suscan
suwidgets
volk

doronbehar · 2024-07-28T07:39:49Z

Result of nixpkgs-review pr 330477 run on x86_64-linux 1

14 packages failed to build:

gnuradio3_8
gnuradio3_8Minimal
gnuradio3_8Packages.ais
gnuradio3_8Packages.grnet
gnuradio3_8Packages.limesdr
gnuradio3_8Packages.osmosdr
gnuradio3_8Packages.osmosdr.dev
gnuradio3_8Packages.rds
gnuradio3_9
gnuradio3_9Packages.grnet
gnuradio3_9Packages.osmosdr
gnuradio3_9Packages.osmosdr.dev
inspectrum
qradiolink

15 packages built:

gnss-sdr
gnuradio
gnuradioMinimal (gnuradio3_9Minimal)
gnuradioPackages.osmosdr
gnuradioPackages.osmosdr.dev
gqrx
gqrx-gr-audio
gqrx-portaudio
nixpkgs-manual
sdrpp
sigdigger
sigutils
suscan
suwidgets
volk

doronbehar · 2024-07-28T08:06:01Z

Hmm very peculiar ... The gnuradio3_8 builds failed for me on x86_64-linux. Also gnuradio3_9 builds failed, but in a slightly different manner.

I pushed a few more commits for to these attributes. If @tie you'd be kind enough to run a nixpkgs-review again for these commits it'd be great, I can cc you when ofborg finished evaluation, so it won't take too much resources from you like before.

tie · 2024-07-28T08:17:01Z

If @tie you'd be kind enough to run a nixpkgs-review again

I assume this is a typo and you wanted to ping @tko 😅
But feel free to also ping me, I can run nixpkgs-review on aarch64-linux.

tko · 2024-07-28T08:58:29Z

error:
       … while querying the derivation named 'gr-ais-2020-08-13'
[..]
       error: attribute 'volk' missing

       at /Users/tko/.cache/nixpkgs-review/pr-330477-6/nixpkgs/pkgs/development/gnuradio-modules/mkDerivation.nix:29:59:

           28|     # always be needed
           29|     buildInputs = (args.buildInputs or []) ++ [ unwrapped unwrapped.volk ];
             |                                                           ^
           30|   };

doronbehar · 2024-07-28T09:15:46Z

error:
       … while querying the derivation named 'gr-ais-2020-08-13'
[..]
       error: attribute 'volk' missing

       at /Users/tko/.cache/nixpkgs-review/pr-330477-6/nixpkgs/pkgs/development/gnuradio-modules/mkDerivation.nix:29:59:

           28|     # always be needed
           29|     buildInputs = (args.buildInputs or []) ++ [ unwrapped unwrapped.volk ];
             |                                                           ^
           30|   };

Thanks. At least this error will be fixed now. (will recheck ofborg once more in a while).

doronbehar · 2024-07-28T10:05:26Z

Evaluation finished successfully. Now running nixpkgs-review locally on an x86_64-linux.

doronbehar · 2024-07-28T10:08:03Z

Result of nixpkgs-review pr 330477 run on x86_64-linux 1

25 packages built:

gnss-sdr
gnuradio
gnuradio3_8
gnuradio3_8Minimal
gnuradio3_8Packages.ais
gnuradio3_8Packages.grnet
gnuradio3_8Packages.limesdr
gnuradio3_8Packages.osmosdr
gnuradio3_8Packages.osmosdr.dev
gnuradio3_8Packages.rds
gnuradioMinimal
gnuradioPackages.osmosdr
gnuradioPackages.osmosdr.dev
gqrx
gqrx-gr-audio
gqrx-portaudio
inspectrum
nixpkgs-manual
qradiolink
sdrpp
sigdigger
sigutils
suscan
suwidgets
volk

tko · 2024-07-28T10:49:04Z

Result of nixpkgs-review pr 330477 run on aarch64-darwin 1

1 package marked as broken and skipped:

gnuradio3_8Packages.ais

6 packages failed to build:

gnuradio3_8
gnuradio3_8Minimal
gnuradio3_8Packages.grnet
gnuradio3_8Packages.osmosdr
gnuradio3_8Packages.osmosdr.dev
gnuradio3_8Packages.rds

10 packages built:

gnuradio
gnuradioMinimal
gnuradioPackages.osmosdr
gnuradioPackages.osmosdr.dev
sdrpp
sigdigger
sigutils
suscan
suwidgets
volk

doronbehar · 2024-07-28T10:51:14Z

Thanks for the quick report! Could you share please the build logs of gnuradio3_8Minimal? It is available in logs directory of the nixpkgs-review shell..

tie · 2024-07-28T10:58:28Z

Result of nixpkgs-review pr 330477 run on aarch64-linux 1

24 packages built:

gnss-sdr
gnuradio
gnuradio3_8
gnuradio3_8Minimal
gnuradio3_8Packages.ais
gnuradio3_8Packages.grnet
gnuradio3_8Packages.limesdr
gnuradio3_8Packages.osmosdr
gnuradio3_8Packages.osmosdr.dev
gnuradio3_8Packages.rds
gnuradioMinimal
gnuradioPackages.osmosdr
gnuradioPackages.osmosdr.dev
gqrx
gqrx-gr-audio
gqrx-portaudio
inspectrum
qradiolink
sdrpp
sigdigger
sigutils
suscan
suwidgets
volk

tie · 2024-07-28T10:59:38Z

Had to run with --build-args '--max-jobs 1' because of OOM (with 32GB, 16 cores).

tko · 2024-07-28T11:10:11Z

gnuradio3_8Minimal.log

doronbehar · 2024-07-28T12:28:53Z

Thanks @tko :). This build log I am afraid indicates that for GR 3.8 there is no choice but to go back to volk2, for all platforms. I've found for it an alternative build solution - using Python 3.11 (like GR 3.8 uses), as it still supports the deprecated distutils.

If in an hour or two (after ofborg evaluation finishes) you'd be able to run a nixpkgs-review again, that would be great 🙏.

tko · 2024-07-28T16:31:28Z

Result of nixpkgs-review pr 330477 run on aarch64-darwin 1

1 package marked as broken and skipped:

gnuradio3_8Packages.ais

2 packages failed to build:

sigdigger
suscan

14 packages built:

gnuradio
gnuradio3_8
gnuradio3_8Minimal
gnuradio3_8Packages.grnet
gnuradio3_8Packages.osmosdr
gnuradio3_8Packages.osmosdr.dev
gnuradio3_8Packages.rds
gnuradioMinimal
gnuradioPackages.osmosdr
gnuradioPackages.osmosdr.dev
sdrpp
sigutils
suwidgets
volk

The build error looks to have been suscan, dependency of sigdigger

-- Could NOT find ZLIB (missing: ZLIB_LIBRARY) (found version "1.2.11")
[..]
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
ZLIB_LIBRARY
    linked by target "suscan" in directory /tmp/nix-build-suscan-unstable-2022-07-05.drv-0/source

doronbehar · 2024-07-28T17:00:14Z

Thanks again for the report @tko. Maybe an update to suscan will fix the issue. I checked that sigdigger compiles on x86_64-linux with the suscan update I just pushed, and I checked basic functionality of both packages' commands.

I will give a few days for the maintainers of both packages (@polygon and @oxapentane) to respond to this suscan update, and I will also let a few more days for ofborg to build this on aarch64-darwin. If you really want to speed things up, you can run a nixpkgs-review once more, but that's up to you :). Thanks again for contributing your local hardware's time :).

doronbehar · 2024-07-28T17:03:52Z

@ofborg build sigdigger

tko · 2024-07-28T17:21:28Z

I see same error from suscan-0.3.0

-- Could NOT find ZLIB (missing: ZLIB_LIBRARY) (found version "1.2.11")
[..]
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
ZLIB_LIBRARY
    linked by target "suscan" in directory /tmp/nix-build-suscan-0.3.0.drv-0/source

doronbehar · 2024-07-29T05:35:35Z

OK I found out that the suscan update wasn't really an update - upstream only decided to tag the same revision that we used as v0.3.0 . Makes the expression nicer, but of course it won't solve the zlib issue.

I fixed the expression to use rev = "v${version}";. And I won't make an effort to fix that. It is barely related to this update, and I can't fix that without my hands on a Darwin machine. I also expect Darwin users to experience this issue in the next channel update (if there are Darwin users that use this package).

I'll give a few days for the maintainers of suscan to respond, and I'll merge this in a few days.

Diff: gnuradio/volk@v3.0.0...v3.1.2

Encounteres an error gnuradio3_8 also experiences when volkExternal == volk (3.1.2).

doronbehar · 2024-07-31T09:38:35Z

OK suscan was broken apparently on all platforms - I missed that because my branch wasn't rebased upon latest master, and ofborg didn't miss that. Now it should be fixed. I'll wait for CI to be greener and I'll merge this.

pkgs/by-name/vo/volk2/package.nix

Based on the expression deleted in a previous commit, use this expression in an upcoming commit for gnuradio3_8{,Minimal}.

Nothing really changed, only upstream tagged the same commit as v0.3.0, see: BatchDrake/suscan@37dad54...v0.3.0

doronbehar mentioned this pull request Jul 27, 2024

Build failure: volk #328717

Closed

ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Jul 27, 2024

tko reviewed Jul 27, 2024

View reviewed changes

pkgs/by-name/vo/volk/package.nix Show resolved Hide resolved

doronbehar force-pushed the pkg/volk3 branch from 0ffc4db to 5cb4cc7 Compare July 27, 2024 19:50

tko reviewed Jul 27, 2024

View reviewed changes

pkgs/by-name/vo/volk/package.nix Show resolved Hide resolved

doronbehar linked an issue Jul 27, 2024 that may be closed by this pull request

Build failure: volk #328717

Closed

doronbehar force-pushed the pkg/volk3 branch from 5cb4cc7 to 6b7a746 Compare July 28, 2024 08:05

doronbehar force-pushed the pkg/volk3 branch from 6b7a746 to f8d45f1 Compare July 28, 2024 08:40

doronbehar force-pushed the pkg/volk3 branch from f8d45f1 to 55002d6 Compare July 28, 2024 09:14

ofborg bot added the 8.has: clean-up label Jul 28, 2024

ofborg bot requested review from mogorman, fpletz, jiegec and bjornfor July 28, 2024 09:46

doronbehar changed the title ~~volk: 3.0.0 -> 3.1.2; cleanup~~ volk: 3.0.0 -> 3.1.2 Jul 28, 2024

doronbehar force-pushed the pkg/volk3 branch from 55002d6 to 0933fdc Compare July 28, 2024 12:28

ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 28, 2024

ofborg bot requested review from gshipunov and polygon July 28, 2024 18:45

doronbehar force-pushed the pkg/volk3 branch from 6d16a2b to 69ca344 Compare July 29, 2024 05:32

doronbehar added 6 commits July 31, 2024 12:21

volk: 2.5.0 -> 3.0.0 (for aarch64-darwin only); move to pkgs/by-name

084f522

volk: 3.0.0 -> 3.1.2; cleanup

9964f0d

Diff: gnuradio/volk@v3.0.0...v3.1.2

volk: nixfmt (rfc 166)

61a18c5

gnuradio3_9: try to fix build by disabling doxygen

d15b722

Encounteres an error gnuradio3_8 also experiences when volkExternal == volk (3.1.2).

gnuradio3_9{,Minimal}: remove

47fa617

gnuradio3_8Packages.ais: mark as broken on Darwin

06823da

doronbehar force-pushed the pkg/volk3 branch from 69ca344 to d417862 Compare July 31, 2024 09:24

SuperSandro2000 reviewed Jul 31, 2024

View reviewed changes

pkgs/by-name/vo/volk2/package.nix Outdated Show resolved Hide resolved

pkgs/by-name/vo/volk2/package.nix Outdated Show resolved Hide resolved

pkgs/by-name/vo/volk2/package.nix Outdated Show resolved Hide resolved

doronbehar added 5 commits July 31, 2024 13:14

volk_2: init at 2.5.0

87e26ee

Based on the expression deleted in a previous commit, use this expression in an upcoming commit for gnuradio3_8{,Minimal}.

gnuradio3_8: fix build by using volk_2

97f944d

suscan: unstable-2022-07-05 -> 0.3.0

a77ec88

Nothing really changed, only upstream tagged the same commit as v0.3.0, see: BatchDrake/suscan@37dad54...v0.3.0

suscan: fix build by adding zlib

bb01e59

gnuradio{,3_8}: use removeReferencesTo from nativeBuildInputs

cae1f15

doronbehar force-pushed the pkg/volk3 branch from d417862 to cae1f15 Compare July 31, 2024 10:22

doronbehar merged commit 79860d1 into NixOS:master Aug 3, 2024
26 of 27 checks passed

doronbehar deleted the pkg/volk3 branch August 3, 2024 18:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

volk: 3.0.0 -> 3.1.2 #330477

volk: 3.0.0 -> 3.1.2 #330477

doronbehar commented Jul 27, 2024

tko commented Jul 27, 2024

doronbehar commented Jul 27, 2024 •

edited

Loading

tko commented Jul 28, 2024

doronbehar commented Jul 28, 2024

doronbehar commented Jul 28, 2024

tie commented Jul 28, 2024

tko commented Jul 28, 2024

doronbehar commented Jul 28, 2024

doronbehar commented Jul 28, 2024

doronbehar commented Jul 28, 2024

tko commented Jul 28, 2024

doronbehar commented Jul 28, 2024

tie commented Jul 28, 2024

tie commented Jul 28, 2024

tko commented Jul 28, 2024

doronbehar commented Jul 28, 2024

tko commented Jul 28, 2024

doronbehar commented Jul 28, 2024

doronbehar commented Jul 28, 2024

tko commented Jul 28, 2024

doronbehar commented Jul 29, 2024

doronbehar commented Jul 31, 2024

volk: 3.0.0 -> 3.1.2 #330477

volk: 3.0.0 -> 3.1.2 #330477

Conversation

doronbehar commented Jul 27, 2024

Description of changes

Things done

tko commented Jul 27, 2024

doronbehar commented Jul 27, 2024 • edited Loading

tko commented Jul 28, 2024

doronbehar commented Jul 28, 2024

doronbehar commented Jul 28, 2024

tie commented Jul 28, 2024

tko commented Jul 28, 2024

doronbehar commented Jul 28, 2024

doronbehar commented Jul 28, 2024

doronbehar commented Jul 28, 2024

tko commented Jul 28, 2024

doronbehar commented Jul 28, 2024

tie commented Jul 28, 2024

tie commented Jul 28, 2024

tko commented Jul 28, 2024

doronbehar commented Jul 28, 2024

tko commented Jul 28, 2024

doronbehar commented Jul 28, 2024

doronbehar commented Jul 28, 2024

tko commented Jul 28, 2024

doronbehar commented Jul 29, 2024

doronbehar commented Jul 31, 2024

doronbehar commented Jul 27, 2024 •

edited

Loading