Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Add teamtalk5 #376817

Closed
wants to merge 0 commits into from
Closed

WIP Add teamtalk5 #376817

wants to merge 0 commits into from

Conversation

347Online
Copy link
Contributor

@347Online 347Online commented Jan 25, 2025

New Package TeamTalk

Add self to maintainers list

TeamTalk 5 is a freeware conferencing system which allows multiple users to participate in audio and video conversations
https://bearware.dk

Things done

  • Built on platform(s)
    • x86_64-linux - WIP
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 25, 2025
@347Online
Copy link
Contributor Author

All seems to be in order on aarch64-darwin.

I am still working on packaging for x86_64-linux, I'm currently having trouble correctly supplying all the right Qt libraries. I want to try some things before I open a thread on Discourse, but I will likely do that soon.

Any initial feedback or assistance would be greatly appreciated, thank you

@github-actions github-actions bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 26, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/help-packaging-qt5-binary-application-teamtalk5/59390/1

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 26, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Jan 26, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Jan 29, 2025
@347Online
Copy link
Contributor Author

Okay, so I've been able to get it to run on NixOS, but only with nix develop

If I try to run the binary normally I still get

qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in ""
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

zsh: IOT instruction (core dumped)  nix run .\#teamtalk5 --impure

(Impure because this is an unfree package)

I've tried every possible permutation I could come up with from digging around to pass args to wrapQtAppsHook, any advice would be greatly appreciated

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 19, 2025
@347Online 347Online closed this Feb 19, 2025
@eclairevoyant
Copy link
Contributor

If I try to run the binary normally I still get

qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in ""
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

zsh: IOT instruction (core dumped)  nix run .\#teamtalk5 --impure

If you're on wayland you may need to install qtwayland separately.
Also I believe your force-push may have been empty somehow, which GH believes means you want to close a PR - though you're welcome to create a new PR.

@347Online
Copy link
Contributor Author

Oops, yeah I can make a new PR.

Hmm... you're saying I just need to add qtwayland to my package set? That seems odd, I would think I should get it into derivation, so when you install it should just work?

When I make the new PR I'll keep playing with it

@eclairevoyant
Copy link
Contributor

eclairevoyant commented Feb 19, 2025

Hmm... you're saying I just need to add qtwayland to my package set?

Unfortunately, yes. That seems to play better with the Qt plugin paradigm than including it in package inputs. At least, that's the case with Qt 6, I haven't tested with Qt 5 offhand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants