Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alertmanager-gotify-bridge: init at 2.3.2 #378055

Merged
merged 3 commits into from
Feb 17, 2025
Merged

alertmanager-gotify-bridge: init at 2.3.2 #378055

merged 3 commits into from
Feb 17, 2025

Conversation

juli0604
Copy link
Contributor

@juli0604 juli0604 commented Jan 30, 2025 •
edited
Loading

See DRuggeri/alertmanager_gotify_bridge#37

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@felbinger
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 378055

Logs: https://github.com/felbinger/nixpkgs-review-gha/actions/runs/13057655441

x86_64-linux

✅ 1 package built:
  • alertmanager-gotify-bridge

aarch64-linux

✅ 1 package built:
  • alertmanager-gotify-bridge

x86_64-darwin

✅ 1 package built:
  • alertmanager-gotify-bridge

aarch64-darwin

✅ 1 package built:
  • alertmanager-gotify-bridge

steeleduncan
steeleduncan suggested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@steeleduncan steeleduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit that adds you to the maintainers list should be add rather than init

pkgs/by-name/al/alertmanager-gotify-bridge/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/al/alertmanager-gotify-bridge/package.nix Outdated Show resolved Hide resolved
@juli0604 juli0604 force-pushed the alertmanager-gotify branch from bede056 to feb0488 Compare January 31, 2025 14:38
@juli0604 juli0604 force-pushed the alertmanager-gotify branch from feb0488 to 6e3b794 Compare February 11, 2025 21:12
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 11, 2025
@juli0604 juli0604 force-pushed the alertmanager-gotify branch from 6e3b794 to 0263501 Compare February 11, 2025 21:15
@juli0604 juli0604 marked this pull request as ready for review February 11, 2025 21:20
@felbinger
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 378055

Logs: https://github.com/felbinger/nixpkgs-review-gha/actions/runs/13272652465

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • alertmanager-gotify-bridge

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • alertmanager-gotify-bridge

x86_64-darwin

✅ 1 package built:
  • alertmanager-gotify-bridge

aarch64-darwin

✅ 1 package built:
  • alertmanager-gotify-bridge

@juli0604 juli0604 force-pushed the alertmanager-gotify branch from 0263501 to 26992ce Compare February 15, 2025 14:35
@felbinger
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 378055

Logs: https://github.com/felbinger/nixpkgs-review-gha/actions/runs/13346027194

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • alertmanager-gotify-bridge

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • alertmanager-gotify-bridge

x86_64-darwin

✅ 1 package built:
  • alertmanager-gotify-bridge

aarch64-darwin

✅ 1 package built:
  • alertmanager-gotify-bridge

Defelo
Defelo reviewed Feb 15, 2025
View reviewed changes
pkgs/by-name/al/alertmanager-gotify-bridge/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/al/alertmanager-gotify-bridge/package.nix Show resolved Hide resolved
pkgs/by-name/al/alertmanager-gotify-bridge/package.nix Show resolved Hide resolved
nixos/modules/services/monitoring/prometheus/alertmanager-gotify-bridge.nix Outdated Show resolved Hide resolved
nixos/modules/services/monitoring/prometheus/alertmanager-gotify-bridge.nix Outdated Show resolved Hide resolved
nixos/modules/services/monitoring/prometheus/alertmanager-gotify-bridge.nix Outdated Show resolved Hide resolved
nixos/modules/services/monitoring/prometheus/alertmanager-gotify-bridge.nix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible / make sense to add NixOS tests for this module?

@Defelo
Copy link
Member

Defelo commented Feb 15, 2025

Also, please update the version in your PR title

@juli0604 juli0604 changed the title alertmanager-gotify-bridge: init at 2.3.1 alertmanager-gotify-bridge: init at 2.3.2 Feb 16, 2025
@juli0604 juli0604 force-pushed the alertmanager-gotify branch from 26992ce to e30783a Compare February 16, 2025 14:01
@juli0604 juli0604 force-pushed the alertmanager-gotify branch from e30783a to 7138dd4 Compare February 16, 2025 21:33
@juli0604 juli0604 force-pushed the alertmanager-gotify branch from 7138dd4 to a919728 Compare February 16, 2025 21:39
@SuperSandro2000 SuperSandro2000 merged commit 8a3e6de into NixOS:master Feb 17, 2025
8 checks passed
@felbinger felbinger added the backport release-24.11 Backport PR automatically label Feb 18, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 18, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Feb 18, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@Defelo Defelo Defelo left review comments

@steeleduncan steeleduncan steeleduncan requested changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juli0604 @felbinger @Defelo @steeleduncan @SuperSandro2000