Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

longcat: init at 0.0.12 #380813

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

longcat: init at 0.0.12 #380813

wants to merge 1 commit into from
+39 −0

Conversation

bubblepipe
Copy link

@bubblepipe bubblepipe commented Feb 10, 2025 •
edited
Loading

longcat

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Feb 10, 2025
@yzx9
Copy link
Contributor

yzx9 commented Feb 15, 2025

Fantastic package! 😆

It works great, but could you squash your commits to follow the commit conventions? Once that’s done, you can mark the PR as ready.

yzx9
yzx9 suggested changes Feb 15, 2025
View reviewed changes
pkgs/by-name/lo/longcat/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/lo/longcat/package.nix Show resolved Hide resolved
pkgs/by-name/lo/longcat/package.nix Outdated Show resolved Hide resolved
@bubblepipe
Copy link
Author

Fantastic package! 😆

It works great, but could you squash your commits to follow the commit conventions? Once that’s done, you can mark the PR as ready.

Thank you very much for the suggestions! Let me know if there are any other improvements.

@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: kernel The Linux kernel 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: printing 6.topic: rust 6.topic: golang 6.topic: ruby 6.topic: vim 6.topic: ocaml 6.topic: xfce The Xfce Desktop Environment 6.topic: nodejs 6.topic: hardware 6.topic: coq "A formal proof management system" 6.topic: pantheon The Pantheon desktop environment 6.topic: TeX Issues regarding texlive and TeX in general labels Feb 15, 2025
@github-actions github-actions bot removed 6.topic: cinnamon Desktop environment 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: module system About "NixOS" module system internals 6.topic: games 6.topic: systemd 6.topic: php 6.topic: cuda Parallel computing platform and API 6.topic: deepin Desktop environment and its components 6.topic: vscode 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: flakes The experimental Nix feature 6.topic: nvidia 6.topic: lib The Nixpkgs function library 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: teams Relating to team creation, updates, other management actions labels Feb 15, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 15, 2025
@bubblepipe bubblepipe marked this pull request as ready for review February 15, 2025 13:21
@yzx9
Copy link
Contributor

yzx9 commented Feb 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380813

aarch64-darwin

✅ 1 package built:
  • longcat

@bubblepipe
Copy link
Author

bubblepipe commented Feb 17, 2025 •
edited
Loading

@yzx9 Could you please help me check the status of OfBorg / longcat, longcat.passthru.tests on aarch64-linux? It has been stalled for over a day. I am quite confused with the ofbrog log viewer.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 17, 2025
@yzx9
Copy link
Contributor

yzx9 commented Feb 17, 2025

Don't worry about it! ofBorg often gets stuck, and we actually don’t provide tests. It's not a problem. If you want to get merged quickly, try following the guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzx9 yzx9 yzx9 approved these changes

Assignees
No one assigned
Labels
6.topic: policy discussion 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle! backport release-24.11 Backport PR automatically
Projects
CUDA Team
Status: 📋 The forgotten
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bubblepipe @yzx9 @wegank @NixOSInfra