bunster: init at v0.8.0 #382239
Open
bunster: init at v0.8.0 #382239
+46
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
NixOSInfra
added
the
12. first-time contribution
ethancedwards8
suggested changes
Feb 15, 2025
pkgs/by-name/bu/bunster/package.nix
Outdated
| src = fetchFromGitHub { | ||
| owner = "yassinebenaid"; | ||
| repo = "bunster"; | ||
| rev = "v${version}"; |
There was a problem hiding this comment.
Thanks for looking over, will do!
| }; | ||
|
|
||
| vendorHash = "sha256-Gs+8J+yEVynsBte3Hnx7jnYRPa/61CIISDbMyDKhPRE="; | ||
| doCheck = false; |
There was a problem hiding this comment.
Why no checks? They are preferred. Please enable them or add a comment stating why they don't work.
There was a problem hiding this comment.
checks fail on aarch64-darwin but binary still builds successfully. tests run fine when done manually and from my testing binary seems to run with no bugs asw. x86 Linux doesn't have this problem
There was a problem hiding this comment.
Suggested change
| doCheck = false; | |
| doCheck = !stdenv.hostPlatform.isDarwin;; |
|
Some suggestions: (including suggestions from the previous review) diff --git a/pkgs/by-name/bu/bunster/package.nix b/pkgs/by-name/bu/bunster/package.nix
index 7048b95c19bd..5181f4c6a2f2 100644
--- a/pkgs/by-name/bu/bunster/package.nix
+++ b/pkgs/by-name/bu/bunster/package.nix
@@ -2,6 +2,8 @@
lib,
buildGoModule,
fetchFromGitHub,
+ versionCheckHook,
+ nix-update-script,
}:
buildGoModule rec {
@@ -11,16 +13,23 @@ buildGoModule rec {
src = fetchFromGitHub {
owner = "yassinebenaid";
repo = "bunster";
- rev = "v${version}";
+ tag = "v${version}";
hash = "sha256-ZooaM9zi6tC7Y6Oks7OEtMPX0+4kd1UaBGzfNLgCj10=";
};
vendorHash = "sha256-Gs+8J+yEVynsBte3Hnx7jnYRPa/61CIISDbMyDKhPRE=";
- doCheck = false;
+ doCheck = true;
+
+ nativeInstallCheckInputs = [ versionCheckHook ];
+ doInstallCheck = true;
+ versionCheckProgramArg = "version";
+
+ passthru.updateScript = nix-update-script {};
meta = {
- description = "Compile shell scripts to static binaries.";
+ description = "Compile shell scripts to static binaries";
homepage = "https://github.com/yassinebenaid/bunster";
+ changelog = "https://github.com/yassinebenaid/bunster/releases/tag/v{version}";
license = lib.licenses.bsd3;
maintainers = with lib.maintainers; [
yunz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.