-
-
Notifications
You must be signed in to change notification settings - Fork 16.2k
nixos: add boot.isVM option #390897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
nixos: add boot.isVM option #390897
Conversation
This adds an option, similar to boot.isContainer, to gate the configuration of qemu-vm.nix behind, which is now imported by default. This solves the longstanding issue that users would get errors about the `virtualisation.*` not existing when used outside of the scope of `virtualisation.vmVariant`, while at same time being listed in the NixOS manual.
This seems backwards compared to So the analogy is backwards. The option should be named something more indicative of the fact that users should set it to turn a module on. Finally, I'm still not sure this is a good idea. It's really weird to create an option that results in the |
An alternative would be to move the qemu-vm.nix options from the top-evel to something like
Ok, but I think the current situation is worse: the options are documented, interspersed with unrelated modules using the same namespace, not enabled by default and it's not clear that you have to import qemu-vm.nix to use them. I've see at least a dozen posts about this on the forum. |
This adds an option, similar to boot.isContainer, to gate the
configuration of qemu-vm.nix behind, which is now imported by default.
This solves the longstanding issue that users would get errors about the
virtualisation.*
not existing when used outside of the scope ofvirtualisation.vmVariant
, while at same time being listed in the NixOSmanual.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
Add a 👍 reaction to pull requests you find important.