Skip to content

stdenv/darwin: disable gnugrep tests in early bootstrap #398385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2025

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Apr 13, 2025

Yes, this is going to master for a reason.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy requested a review from a team April 13, 2025 14:29
@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Apr 13, 2025
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 13, 2025
@vcunat vcunat added the 1.severity: channel blocker Blocks a channel label Apr 13, 2025
@vcunat
Copy link
Member

vcunat commented Apr 13, 2025

Building at https://hydra.nixos.org/eval/1814622

@emilazy emilazy added backport staging-24.11 Backport PR automatically and removed 6.topic: darwin Running or building packages on Darwin 1.severity: channel blocker Blocks a channel labels Apr 13, 2025
@vcunat vcunat force-pushed the push-lnovzozrtrlq branch from 5008621 to f04c9b1 Compare April 13, 2025 17:51
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 13, 2025
@vcunat vcunat marked this pull request as ready for review April 13, 2025 17:51
@vcunat
Copy link
Member

vcunat commented Apr 13, 2025

Rebased to fix CI.

@nix-owners nix-owners bot requested review from toonn and reckenrode April 13, 2025 17:53
@github-actions github-actions bot added 10.rebuild-darwin: 5001+ 10.rebuild-darwin: 501+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 13, 2025
@vcunat
Copy link
Member

vcunat commented Apr 13, 2025

Heh, well, the part of CI trying to find package called stdenv/darwin won't work...

@vcunat vcunat merged commit e168d09 into NixOS:master Apr 13, 2025
39 of 42 checks passed
@github-project-automation github-project-automation bot moved this to Done in Stdenv Apr 13, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Apr 13, 2025

Successfully created backport PR for staging-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: stdenv Standard environment 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux backport staging-24.11 Backport PR automatically
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants