-
-
Notifications
You must be signed in to change notification settings - Fork 16.3k
nixos/direnv: fix silent option #398717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
nixos/direnv: fix silent option #398717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaneliman
reviewed
Apr 15, 2025
eclairevoyant
suggested changes
Apr 18, 2025
eclairevoyant
approved these changes
Apr 18, 2025
khaneliman
added a commit
to khaneliman/home-manager
that referenced
this pull request
Apr 18, 2025
Discussion and retesting in NixOS/nixpkgs#398717. The env variable is actually not needed when you use the config.
6 tasks
khaneliman
added a commit
to khaneliman/home-manager
that referenced
this pull request
Apr 18, 2025
Discussion and retesting in NixOS/nixpkgs#398717. The env variable is actually not needed when you use the config.
13 tasks
This breaks the evaluation of nixos. PR to suggest a fix #399966 |
Oh, Gerg, I found out what else you forgot: since the variables are gone,
settings = lib.mkIf cfg.silent {
global.log_format = "-";
};
|
What do you mean by that? programs = {
direnv.settings = lib.mkIf cfg.silent {
global = {
log_format = lib.mkDefault "-";
log_filter = lib.mkDefault "^$";
};
}; |
whoops, i'm blind, sorry for bothering 🙈 |
khaneliman
added a commit
to nix-community/home-manager
that referenced
this pull request
Apr 21, 2025
Discussion and retesting in NixOS/nixpkgs#398717. The env variable is actually not needed when you use the config.
3 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin.
10.rebuild-linux: 1-10
This PR causes between 1 and 10 packages to rebuild on Linux.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$DIRENV_LOG_FORMAT
is currently broken see: direnv/direnv#1418this PR fixes the
silent
option and adds thesettings
optionThings done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.