telegram-desktop: 5.14.3 -> 5.15.2#414062
Conversation
|
For good measure I rebuilt |
It's not even merged |
|
Oh, sorry for my ignorance. Wasn't really paying attention... I assumed that was the change that did it as it referenced a lot of the same libraries I needed to add. Then I don't know what is the breaking change, but it isn't really that important anyways. I know that it doesn't build without adding them, and that I got a working build this way. |
7df80ae to
2b580e6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
2b580e6 to
b7cfcd3
Compare
pkgs/applications/networking/instant-messengers/telegram/telegram-desktop/unwrapped.nix
Show resolved
Hide resolved
NickCao
left a comment
There was a problem hiding this comment.
LGTM, do we want to create a symlink telegram-desktop -> Telegram for compatibility?
|
Don't know, most people launch it from the desktop files anyways, which have been updated upstream. I think the |
Other platforms didn't change binary name.
This feels natural, that way you don't have to change multiple places |
Fixes NixOS#417883 This is due to the breaking commit b7cfcd3 See also: NixOS#414062
|
Is there way to notify users about deprecated binary name then? |
|
I've put it in the release notes: #418455 |
tg_owtrevision is the one upstream uses in their docker build environment as of now.Release: https://github.com/telegramdesktop/tdesktop/releases/tag/v5.15.0
Diff: telegramdesktop/tdesktop@v5.14.3...v5.15.0
No tdlib update, so I assume I don't need to update the forks at the same time?
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.