Skip to content

telegram-desktop: 5.14.3 -> 5.15.2#414062

Merged
NickCao merged 4 commits intoNixOS:masterfrom
dtomvan:dtomvan/push-twponmpzqpon
Jun 7, 2025
Merged

telegram-desktop: 5.14.3 -> 5.15.2#414062
NickCao merged 4 commits intoNixOS:masterfrom
dtomvan:dtomvan/push-twponmpzqpon

Conversation

@dtomvan
Copy link
Contributor

@dtomvan dtomvan commented Jun 4, 2025

tg_owt revision is the one upstream uses in their docker build environment as of now.

Release: https://github.com/telegramdesktop/tdesktop/releases/tag/v5.15.0
Diff: telegramdesktop/tdesktop@v5.14.3...v5.15.0

No tdlib update, so I assume I don't need to update the forks at the same time?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 4, 2025
@nix-owners nix-owners bot requested a review from NickCao June 4, 2025 21:42
@dtomvan
Copy link
Contributor Author

dtomvan commented Jun 5, 2025

For good measure I rebuilt materialgram on this branch, which worked.

@ilya-fedin
Copy link
Contributor

Change that "broke" the build (hence new deps): telegramdesktop/tdesktop#29371

It's not even merged

@dtomvan
Copy link
Contributor Author

dtomvan commented Jun 5, 2025

Oh, sorry for my ignorance. Wasn't really paying attention... I assumed that was the change that did it as it referenced a lot of the same libraries I needed to add. Then I don't know what is the breaking change, but it isn't really that important anyways. I know that it doesn't build without adding them, and that I got a working build this way.

@dtomvan dtomvan changed the title telegram-desktop: 5.14.3 -> 5.15.0 telegram-desktop: 5.14.3 -> 5.15.2 Jun 5, 2025
@dtomvan dtomvan force-pushed the dtomvan/push-twponmpzqpon branch from 7df80ae to 2b580e6 Compare June 5, 2025 21:15
@dtomvan

This comment was marked as outdated.

@dtomvan dtomvan force-pushed the dtomvan/push-twponmpzqpon branch from 2b580e6 to b7cfcd3 Compare June 5, 2025 21:56
@github-actions github-actions bot added the 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. label Jun 5, 2025
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we want to create a symlink telegram-desktop -> Telegram for compatibility?

@dtomvan
Copy link
Contributor Author

dtomvan commented Jun 7, 2025

Don't know, most people launch it from the desktop files anyways, which have been updated upstream. I think the installPhase (which references mainProgram, which might be a bad thing) should also work on MacOS since they also did the rename for that platform upstream.

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Jun 7, 2025

since they also did the rename for that platform

Other platforms didn't change binary name. telegram-desktop was linux-with-non-hardcoded-path-mode-specific.

which references mainProgram, which might be a bad thing

This feels natural, that way you don't have to change multiple places

@NickCao NickCao merged commit ad47117 into NixOS:master Jun 7, 2025
16 of 18 checks passed
@dtomvan dtomvan deleted the dtomvan/push-twponmpzqpon branch June 7, 2025 21:15
dtomvan added a commit to dtomvan/nixpkgs that referenced this pull request Jun 20, 2025
@kaeeraa
Copy link
Member

kaeeraa commented Aug 15, 2025

Is there way to notify users about deprecated binary name then?

@dtomvan
Copy link
Contributor Author

dtomvan commented Aug 17, 2025

I've put it in the release notes: #418455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants