-
-
Notifications
You must be signed in to change notification settings - Fork 16.2k
treewide: migrate nixos modules to networking.hosts #414780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: migrate nixos modules to networking.hosts #414780
Conversation
Signed-off-by: John Titor <[email protected]>
Tests built successfully on nix community linux builder..
|
and so |
Could you give me 2 hrs? I can try preparing a fix, else I'll open a revert PR. |
This broke eval for simple nixos containers like:
|
I absoulutely love how these aren't caught by our nixosTests.containers-hosts. Revert PR: #415085 |
Split off from #413925 as this doesn't need a discussion on whether extraHosts need to be kept.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usageAdd a 👍 reaction to pull requests you find important.