build-support/rust: support default_features in cargo manifest#417808
Merged
andresilva merged 1 commit intoNixOS:stagingfrom Jul 10, 2025
Merged
build-support/rust: support default_features in cargo manifest#417808andresilva merged 1 commit intoNixOS:stagingfrom
andresilva merged 1 commit intoNixOS:stagingfrom
Conversation
Member
Author
|
I encountered this issue while trying to build a rust package (some transitive dependency used |
github-actions
bot
added
10.rebuild-darwin: 501+
Member
Author
|
Would appreciate a review on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/rust-lang/cargo/blob/master/crates/cargo-util-schemas/src/manifest/mod.rs#L706
https://github.com/rust-lang/cargo/blob/master/crates/cargo-util-schemas/src/manifest/mod.rs#L719-L721
https://github.com/rust-lang/cargo/blob/master/crates/cargo-util-schemas/manifest.schema.json#L807
default_featuresis still supported by Cargo even though it's "soft" deprecated. Cargo handles both keys the same way as implemented in this PR, i.e. trydefault-featuresfirst and fallback todefault_features.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.