build-support/rust: support multiple git dependencies with the same version#417900
build-support/rust: support multiple git dependencies with the same version#417900andresilva wants to merge 1 commit intoNixOS:stagingfrom
Conversation
|
Here's an example of something that's fixed by this PR: https://github.com/paritytech/try-runtime-cli/blob/main/Cargo.lock#L15233-L15271 |
|
There have been several fix PRs for this. BTW, have you tested that this works correctly? |
No, I did not test this. It did fix the build of the package I was trying, but it probably would work anyway whatever directory it picked, so maybe that's a false positive. Your fix seems much more extensive, so maybe it's best to just close this PR. |
|
Closing because I'm not sure whether this is correct (I didn't really test whether the correct dependency is being used), and there have been multiple attempts at this problem. |
Add the SHA hash to vendored git dependencies to make sure there are no clashes, since the dependencies might have the same version but point to different git commits.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.