importNpmLock: fix native dependencies for Darwin#423199
Merged
philiptaron merged 1 commit intoNixOS:masterfrom Jul 23, 2025
Merged
importNpmLock: fix native dependencies for Darwin#423199philiptaron merged 1 commit intoNixOS:masterfrom
philiptaron merged 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
6.topic: nodejs
Essentially the same fix as 7945935 for `buildNpmPackage`.
DerGuteMoritz
force-pushed
the
fix-import-npm-lock-for-darwin
branch
from
508be4c to
da4672b
Compare
philiptaron
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essentially the same fix as 7945935 for
buildNpmPackage. Perhaps there should be a bit more code sharing between the two?Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.