nixos/testing: Add onVMHost
attribute to all tests
#423276
Open
+41
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interaction between
pkg.override*
and alternate VM hosts does not work.Concretely, if I'm using Darwin, and I'm developing a patch to a linux package, I'd want to do
(pkg.overrideAttrs someFunction).tests
, but this does not work, because that will (have to) use the Linux version of the package, whereas we've added our patch (insomeFunction
) to a Darwin instantiation of the package.The test framework can compensate for this.
Instead, with this PR, you could override the Linux package, and then build something like
(pkg.overrideAttrs someFunction).tests.nixos.onVMHost.aarch64-darwin
(wherepkg
is for Linux).Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.