Skip to content

python313Packages.mayavi: unmark broken #448443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

python313Packages.mayavi: unmark broken #448443

merged 1 commit into from
Oct 14, 2025
+1 −4

Conversation

qbisi
Copy link
Contributor

@qbisi qbisi commented Oct 4, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 4, 2025
@qbisi
Copy link
Contributor Author

qbisi commented Oct 4, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 448443
Commit: 31bfb9a81bb17d8a527327a8a4f379c236c6b210 (subsequent changes)
Merge: e137fa5971ea26be90f88be78bd3daaffe79c667

Logs: https://github.com/qbisi/nixpkgs-review-gha/actions/runs/18239918978

x86_64-linux

✅ 2 packages built:
  • python313Packages.mayavi
  • python313Packages.mayavi.dist

aarch64-linux

✅ 2 packages built:
  • python313Packages.mayavi
  • python313Packages.mayavi.dist

x86_64-darwin (sandbox = true)

❌ 2 packages failed to build:
  • python313Packages.mayavi
  • python313Packages.mayavi.dist

aarch64-darwin (sandbox = true)

❌ 2 packages failed to build:
  • python313Packages.mayavi
  • python313Packages.mayavi.dist

@qbisi
Copy link
Contributor Author

qbisi commented Oct 4, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 448443
Commit: 31bfb9a81bb17d8a527327a8a4f379c236c6b210

aarch64-darwin

✅ 2 packages built:
  • python313Packages.mayavi
  • python313Packages.mayavi.dist

NickCao
NickCao reviewed Oct 5, 2025
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also drop the now unused pythonAtLeast param.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 5, 2025
@nix-owners nix-owners bot requested a review from natsukium October 13, 2025 23:26
@NickCao NickCao added this pull request to the merge queue Oct 14, 2025
Merged via the queue into NixOS:master with commit 6fd49fb Oct 14, 2025
28 of 31 checks passed
@qbisi qbisi deleted the mayavi branch October 14, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCao NickCao NickCao approved these changes

@natsukium natsukium Awaiting requested review from natsukium

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qbisi @NickCao