Skip to content

python3Packages.pytask: fix tests #451744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

python3Packages.pytask: fix tests #451744

merged 1 commit into from
Oct 14, 2025
+166 −1

Conversation

dotlambda
Copy link
Member

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@dotlambda dotlambda requested a review from erooke October 13, 2025 18:28
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Oct 13, 2025
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 451744
Commit: 34877f9d3614c29e10c36fa6209e29331ad78a38 (subsequent changes)
Merge: 1a9554c5581be1fb1bedb0d4cfb9b596930d1809

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18480829382

x86_64-linux

✅ 4 packages built:
  • python312Packages.pytask
  • python312Packages.pytask.dist
  • python313Packages.pytask
  • python313Packages.pytask.dist

aarch64-linux

✅ 4 packages built:
  • python312Packages.pytask
  • python312Packages.pytask.dist
  • python313Packages.pytask
  • python313Packages.pytask.dist

x86_64-darwin (sandbox = true)

✅ 4 packages built:
  • python312Packages.pytask
  • python312Packages.pytask.dist
  • python313Packages.pytask
  • python313Packages.pytask.dist

aarch64-darwin (sandbox = true)

✅ 4 packages built:
  • python312Packages.pytask
  • python312Packages.pytask.dist
  • python313Packages.pytask
  • python313Packages.pytask.dist

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 14, 2025
erooke
erooke approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@erooke erooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

pkgs/development/python-modules/pytask/default.nix
pname = "pytask";
version = "0.5.5";
pyproject = true;
disabled = pythonOlder "3.8";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how much it matters but the pyproject.toml claims to only support python >= 3.10 while they actively test 3.9 and above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only have Python 3.10 and above in Nixpkgs, so that's more than fine.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 14, 2025
@dotlambda dotlambda added this pull request to the merge queue Oct 14, 2025
Merged via the queue into NixOS:master with commit be1af34 Oct 14, 2025
34 of 37 checks passed
@dotlambda dotlambda deleted the python3Packages.pytask branch October 14, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sigmanificient Sigmanificient Sigmanificient approved these changes

+1 more reviewer

@erooke erooke erooke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dotlambda @Sigmanificient @erooke