Skip to content

nixos/keepalived: support nftables for openFirewall#457523

Open
justinas wants to merge 1 commit intoNixOS:masterfrom
justinas:keepalived-nftables
Open

nixos/keepalived: support nftables for openFirewall#457523
justinas wants to merge 1 commit intoNixOS:masterfrom
justinas:keepalived-nftables

Conversation

@justinas
Copy link
Member

@justinas justinas commented Nov 1, 2025

  • Adds extraInputRules that correspond to extra[Stop]Commands, in order to support nftables-based NixOS firewall
  • Adds an additional NixOS test variant, in order to test under both nftables and iptables firewalls

I recommend reviewing this using the "Hide whitespace changes" option, as the actual changes are pretty minimal, but they resulted in a lot changes to the formatting.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 1, 2025
@justinas justinas force-pushed the keepalived-nftables branch from 527ea13 to e5b46dc Compare November 1, 2025 11:52
@justinas justinas marked this pull request as ready for review November 1, 2025 12:00
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Nov 1, 2025
@justinas justinas force-pushed the keepalived-nftables branch from e5b46dc to 4d773be Compare November 1, 2025 17:10
@nix-owners nix-owners bot requested a review from RaitoBezarius November 1, 2025 17:16
@justinas
Copy link
Member Author

justinas commented Nov 1, 2025

@ofborg test keepalived

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Nov 1, 2025
@justinas justinas force-pushed the keepalived-nftables branch from 4d773be to 2cadaef Compare November 2, 2025 09:55
@justinas
Copy link
Member Author

justinas commented Nov 2, 2025

@ofborg test keepalived

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

1 more reviewer

@ruiiiijiiiiang ruiiiijiiiiang ruiiiijiiiiang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justinas @ruiiiijiiiiang