[Backport release-25.05] workflows/check: run codeowners validator from trusted checkout#457529
Merged
wolfgangwalther merged 2 commits intorelease-25.05from Nov 1, 2025
Merged
Conversation
In f7d6d11 I wrongly assumed that running from the untrusted checkout should be fine for the codeowners validator, because we removed all the logic for privileged tokens. However, this job also contains access to the cachix secret, which could be used to push malicious code to cachix, which would then be pulled by a more privileged workflow like reviewers.yml later. (cherry picked from commit 9718f29)
To be able to disable the pr.yml workflow on GitHub, we need to rename it to a different name. Let's use the long name for consistency with merge-group.yml. This only affects the GitHub-internal name, not the visible name in the PR checklist, which is still "PR". This visible name is also used by nixpkgs-review, so that won't break. (cherry picked from commit f66a380)
nixpkgs-ci
bot
added
the
1.severity: security
1 task
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
nix-owners
bot
requested review from
MattSturgeon,
Mic92,
philiptaron,
wolfgangwalther and
zowoq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-25.05, triggered by a label in #457527.