Skip to content

Conversation

@khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Nov 11, 2025

Follow up to #459608
Closes #460812
Was changed in repo, but has not been changed in luarocks rockspec we fetch.

nvim-telescope/telescope.nvim@7fb51c8

> structuredAttrs is enabled
       > Running phase: unpackPhase
       > unpacking source archive /nix/store/v0a14cg6wb0npnlbjzyagq5x1ih52gb8-source
       > source root is source
       > Running phase: patchPhase
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > Running phase: buildPhase
       > Running phase: installPhase
       >
       >
       > telescope.nvim scm-1 depends on lua 5.1 (5.1-1 provided by VM: success)
       > telescope.nvim scm-1 depends on plenary.nvim (scm-1 installed: success)
       >
       > Error: Directory 'autoload' not found

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Was changed in repo, but has not been changed in luarocks rockspec we
fetch.

nvim-telescope/telescope.nvim@7fb51c8

Signed-off-by: Austin Horstman <[email protected]>
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. labels Nov 12, 2025
@7c6f434c
Copy link
Member

Makes sense and builds.

@7c6f434c 7c6f434c added this pull request to the merge queue Nov 12, 2025
@khaneliman
Copy link
Contributor Author

khaneliman commented Nov 12, 2025

@mrcjkb @teto how do we get their rockspec changes published to luarocks.org ? My other alternative idea was to update luarocks-packages.csv to reference the upstream rockspec directly instead of using that luarocks mirror.. I see us doing that for a few of them in our current list.

Merged via the queue into NixOS:master with commit 71b3650 Nov 12, 2025
31 of 35 checks passed
@khaneliman khaneliman deleted the telescope branch November 12, 2025 00:56
@mrcjkb
Copy link
Member

mrcjkb commented Nov 12, 2025

@mrcjkb @teto how do we get their rockspec changes published to luarocks.org ?

It looks like clason took over maintainership of the project and I think he may be a bit hostile towards the idea of publishing plugins to luarocks. At least doesn't seem to want to maintain the rockspec going forward. @teto what are your thoughts on this? Iirc, he gave you ownership of the luarocks related stuff in nvim-lspconfig?

If they're starting to publish releases again, maybe it's better to use the release rockspec now. But they may also drop the release workflow at some point 😔

Let's await a response to my questions in nvim-telescope/telescope.nvim#3569.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants