Skip to content

Committers process update #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2025
Merged

Committers process update #108

merged 2 commits into from
May 15, 2025

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented May 11, 2025 •
edited
Loading

This ensures that all commit delegators can always be comfortable with all committers.

CC @winterqt

Note that as this changes the commit delegation process, it needs approval from all commit delegators.

@infinisil infinisil requested review from Mic92, NickCao, jtojnar and a team as code owners May 11, 2025 18:09
NickCao
NickCao approved these changes May 11, 2025
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable!

@winterqt winterqt mentioned this pull request May 11, 2025
Merged
infinisil added 2 commits May 14, 2025 16:33
@infinisil
Allow any single Nixpkgs commit delegator to remove committers
102d071 
This ensures that all commit delegators can always be comfortable with
all committers.
@infinisil
Indicate that codeowners should be kept in sync
23445f8
@infinisil infinisil force-pushed the committers-process-update branch from 9549199 to 23445f8 Compare May 14, 2025 14:34
@infinisil infinisil requested a review from winterqt as a code owner May 14, 2025 14:34
@infinisil
Copy link
Member Author

infinisil commented May 14, 2025 •
edited
Loading

(also needs approval from @jtojnar and @winterqt now)

winterqt
winterqt reviewed May 15, 2025
View reviewed changes
winterqt
winterqt approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@winterqt winterqt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've discussed this internally, I think we can give it a go.

@winterqt winterqt removed the request for review from Mic92 May 15, 2025 19:06
jtojnar
jtojnar approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, could potentially lead to instability but if the committer delegation team cannot maintain accord internally, we have a bigger problem.

@jtojnar jtojnar merged commit 32bfedc into main May 15, 2025
2 checks passed
@jtojnar jtojnar deleted the committers-process-update branch May 15, 2025 19:16
@infinisil infinisil mentioned this pull request Jun 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm approved these changes

@jtojnar jtojnar jtojnar approved these changes

@NickCao NickCao NickCao approved these changes

@winterqt winterqt winterqt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@infinisil @zimbatm @jtojnar @NickCao @winterqt