Skip to content

Replace strip-ansi with Node.js native util.stripVTControlCharacters #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LouisAntoninLesieur
Copy link
Contributor

Closes #485

This PR replaces the external strip-ansi dependency with the native Node.js method util.stripVTControlCharacters.

Changes :

  • Removed strip-ansi from dependencies
  • Updated summary.test.js to use util.stripVTControlCharacters
  • Updated cliCommandRunner implementation to rely on the native method

Test :
All tests passed locally using npm run test.

Copy link

codecov bot commented May 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.56%. Comparing base (28ee6a9) to head (e7c2636).
Report is 178 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##            master     #489       +/-   ##
============================================
- Coverage   100.00%   83.56%   -16.44%     
============================================
  Files           15       29       +14     
  Lines          649     1947     +1298     
  Branches         0        1        +1     
============================================
+ Hits           649     1627      +978     
- Misses           0      320      +320     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fraxken fraxken merged commit 145a1a8 into NodeSecure:master May 24, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove strip-ansi for Node.js util.stripVTControlCharacters
2 participants