feat(probes): add isUnsafeSpawn #327
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tony Gorez <[email protected]>
|
I don't worry much about false positive (we could still see in the real world if there is a lot or not). And CLI settings still propose to disable them (I think I will push to make experimental warning disable by default). |
|
Opened an issue in CLI: NodeSecure/cli#493 |
fraxken
reviewed
May 27, 2025
| } | ||
|
|
||
| const command = commandArg.value; | ||
| if (typeof command === "string" && command.includes("csrutil")) { |
There was a problem hiding this comment.
I guess you can create an Array or Set as constants if we have additional values in the future?
There was a problem hiding this comment.
Yeah for sure! The code is still garbage haha :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to introduce
isUnsafeSpwanprobe.I had the idea earlier in the day reading a book on macOS malware where authors try to detect if SIP is enabled (
csrutil).I noticed a bunch of commands that could be suspicious if passed in spawn/exec.
I imaged something where we could have a bunch of specific commands we could mark as suspicious.
My concerns is "What about false positives?" Maybe we would like to have a probe that could take a list of commands and add warnings only for these cases.