New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add recovery ID check to secp256k1_recover syscall #114

Merged

conr2d merged 1 commit into main from syscall-secp256k1_recover

Jan 3, 2025

Contributor

conr2d commented Jan 3, 2025

sp_io::crypto::secp256k1_ecdsa_recover() accepts recovery ID within not only 0..=3, but 27..=31.

To make its behavior align to Solana, this PR updates secp256k1_recover syscall to reject the latter range of recovery ID.


          fix: Add recovery ID check to secp256k1_recover syscall

d928870

conr2d merged commit 20d4f6e into main

4 checks passed

conr2d deleted the syscall-secp256k1_recover branch

January 3, 2025 04:02

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet