chore: Switch Cosmos package dependencies from crate to workspace #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conr2d
reviewed
Jan 10, 2025
Cargo.toml
Outdated
| @@ -77,16 +77,22 @@ bytemuck = "1.16.1" | |||
| bytemuck_derive = "1.7.0" | |||
| byteorder = { version = "1.5.0", default-features = false } | |||
| const-hex = { version = "1.13", default-features = false } | |||
| core2 = { version = "0.4.0", default-features = false } | |||
There was a problem hiding this comment.
You can use nostd::io instead of core2.
Cargo.toml
Outdated
| getrandom = { version = "0.2", default-features = false } | ||
| hex = { version = "0.4", default-features = false } |
There was a problem hiding this comment.
You can use const-hex instead of hex.
| @@ -44,7 +44,7 @@ composable-support = { workspace = true, default-features = false } | |||
| cosmwasm-std = { workspace = true, default-features = false, features = [ | |||
| "iterator", | |||
| "stargate", | |||
| "cosmwasm_1_4", | |||
| "cosmwasm_1_2", | |||
There was a problem hiding this comment.
What's the reason of this downgrade?
conr2d
approved these changes
Jan 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Cosmos packages by transitioning dependencies to workspace-level management, standardizing package metadata, introducing a nostd crate to improve support for no_std environments, and adjusting the cosmwasm-std version.