Add detailed error messaging for reading/writing of model files.#39
Open
Ghatage wants to merge 1 commit intoNolanoOrg:masterfrom
Open
Add detailed error messaging for reading/writing of model files.#39Ghatage wants to merge 1 commit intoNolanoOrg:masterfrom
Ghatage wants to merge 1 commit intoNolanoOrg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to quantize a gptj model and the code failed to quantize it.
I was wondering what the problem was since the error message wasn't very detailed and the help message of the converters weren't very detailed either.
I followed some steps mentioned here: #32 (comment)
Turns out the convert code needs an output directory but the quantize code needs the absolute path to the file name and not an output directory.
So I added some detailed error messaging to clarify that. Now it prints the error code: