Fix incorrect parsing of Out-Of-Band data #287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inputting Out-Of-Band data will never be possible, as the input is not parsed as hex string put every char in the hex string will be converted to its ascii representation thus also only considering the first 8 bytes.
There are some reports considering this issue:
https://devzone.nordicsemi.com/f/nordic-q-a/47932/oob-works-with-mcp-but-fails-with-nrf-connect
https://devzone.nordicsemi.com/f/nordic-q-a/16693/error-oob-static-key-nrf-connect
This pull request will fix this by converting every hex byte in the hex string as byte.