-
-
Notifications
You must be signed in to change notification settings - Fork 18
Add tweak for the old creative menu #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.21
Are you sure you want to change the base?
Conversation
Fix strange hotbar quirk. Fix new inventory showing up for a frame. Fix itempicker having pickall and dragto. Add ability to drop by clicking outside the window.
I appreciate the effort, however I have a few problems with this pull request. First of all the code largely looks like it’s copied from an old version of Minecraft. Furthermore the blocks list is hardcoded with an unnecessary and very verbose option, it should be up to data packs to control the order and blocks listed. Additionally the 0.30 creative menu is very limited and not at all suitable for use apart from some niche cases. |
Not copied but a couple numbers were certainly referenced. The verboseness of the option is yeah dumb, but the creative menu without the old item layout would just look silly really. |
Variable names within the code suggest otherwise. Besides it should not be up to the mod itself to determine the item layout within the inventory |
Ahh yeah okay i see them, I guess I forgot about those haha, those are mostly so creative inventory behaviours match with modern minecraft. |
This PR is a doozy and contains some less than satisfactory code for the sake of customisation.