-
-
Notifications
You must be signed in to change notification settings - Fork 142
utility/nvim-biscuits: init #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add `utility.nvim-biscuits` module. Adds the plugin nvim-biscuits, a rewrite of assorted biscuits.
Add the plugin under my own name instead of @NotAShelf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me except for the release notes entry! welp you fixed it as I was writing the review. LGTM then. (though I'd need to check with @NotAShelf to see if we want all PRs to target the v0.8 branch now or if that's only for language PRs atm)
Thanks for the work :)
Of course, thanks for reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this earlier (shouldn't do reviews this late)
Add the setup function for the nvim-biscuits with setupOps to pluginRC.
Add missing release notes entry, previously only contained a reference to nvim-biscuits github.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One quick change, looks good otherwise. Can be merged with @Soliprem's approval after my comment has been addressed.
Improve the grammar of the `vim.utility.nvim-biscuits.enable` option to read better in documentation. Co-authored-by: raf <[email protected]>
Add
Fixes #1034utility.nvim-biscuits
module. Adds the plugin nvim-biscuits, a rewrite of assorted biscuits.Sanity Checking
nix fmt
).#nix
(default package).#maximal
.#docs-html
(manual, must build).#docs-linkcheck
(optional, please build if adding links)x86_64-linux
aarch64-linux
x86_64-darwin
aarch64-darwin
Add a 👍 reaction to pull requests you find important.