Skip to content

utility/nvim-biscuits: init #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Cool-Game-Dev
Copy link

@Cool-Game-Dev Cool-Game-Dev commented Jul 22, 2025

Add utility.nvim-biscuits module. Adds the plugin nvim-biscuits, a rewrite of assorted biscuits.

Fixes #1034

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

Add `utility.nvim-biscuits` module. Adds the plugin nvim-biscuits, a
rewrite of assorted biscuits.
Copy link

github-actions bot commented Jul 22, 2025

🚀 Live preview deployed from a125a61

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: plugin/nvim-biscuits

Reruns: 1155

Add the plugin under my own name instead of @NotAShelf
Copy link
Collaborator

@Soliprem Soliprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me except for the release notes entry! welp you fixed it as I was writing the review. LGTM then. (though I'd need to check with @NotAShelf to see if we want all PRs to target the v0.8 branch now or if that's only for language PRs atm)

Thanks for the work :)

@Cool-Game-Dev
Copy link
Author

Of course, thanks for reviewing!

Copy link
Collaborator

@Soliprem Soliprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this earlier (shouldn't do reviews this late)

Add the setup function for the nvim-biscuits with setupOps to pluginRC.
Add missing release notes entry, previously only contained a
reference to nvim-biscuits github.
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick change, looks good otherwise. Can be merged with @Soliprem's approval after my comment has been addressed.

Improve the grammar of the `vim.utility.nvim-biscuits.enable` option to read better in documentation.

Co-authored-by: raf <[email protected]>
@NotAShelf NotAShelf requested a review from Soliprem July 23, 2025 21:24
github-actions bot pushed a commit that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin Request: nvim-biscuits
3 participants