Skip to content

utility/telescope: custom extensions API #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 11, 2025
Merged

utility/telescope: custom extensions API #559

merged 12 commits into from
Jun 11, 2025

Conversation

NotAShelf
Copy link
Owner

@NotAShelf NotAShelf commented Jan 14, 2025

Implements a basic telescope.extensions option to take a list of additional extensions with the following schema:

[
  {
  	name = "name of the extension";
  	packages = [ <package & possible dependencies>];
    setup = {
      <extensionName> = { ... }; 
    };
  }
]

Name is used to construct the load_extension line, packages are added to vim.startPlugins verbatim and all setup attrs are merged into one to be passed to telescope's own setup table.

Fixes #542.

@NotAShelf NotAShelf linked an issue Jan 14, 2025 that may be closed by this pull request
1 task
github-actions bot pushed a commit that referenced this pull request Jan 14, 2025
Copy link

github-actions bot commented Jan 14, 2025

🚀 Live preview deployed from 0435104

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: telescope-ext

Reruns: 955

@NotAShelf NotAShelf marked this pull request as ready for review January 14, 2025 14:31
github-actions bot pushed a commit that referenced this pull request Jan 14, 2025
github-actions bot pushed a commit that referenced this pull request Jan 25, 2025
github-actions bot pushed a commit that referenced this pull request Jan 25, 2025
github-actions bot pushed a commit that referenced this pull request Feb 17, 2025
Co-authored-by: Ching Pei Yang <[email protected]>
@NotAShelf NotAShelf force-pushed the main branch 5 times, most recently from 02ee4cc to bc978c4 Compare March 17, 2025 11:42
@NotAShelf NotAShelf requested a review from Soliprem as a code owner March 27, 2025 09:51
github-actions bot pushed a commit that referenced this pull request Mar 27, 2025
@NotAShelf NotAShelf requested a review from horriblename April 28, 2025 05:46
@ItsLiyua
Copy link

ItsLiyua commented Jun 3, 2025

I'd be interested in this! I wanna use some telescope plugins but it's quite difficult to add them as of right now.

@horriblename
Copy link
Collaborator

adding your extensions to startPlugins should work fine currently

@NotAShelf
Copy link
Owner Author

@horriblename could you remind me what the blocker was for this? I don't think API needs further work, but if there's a blocker we can probably look at resolving it for 0.8.

github-actions bot pushed a commit that referenced this pull request Jun 4, 2025
@horriblename
Copy link
Collaborator

it was the fact that nixpkgs telescope extensions add a duplicate telescope package, and messing up lazy loading

I think our little hack (unrelated to this PR) is still working, so we can merge this in first and worry about a proper fix later

horriblename
horriblename previously approved these changes Jun 4, 2025
github-actions bot pushed a commit that referenced this pull request Jun 11, 2025
@NotAShelf NotAShelf force-pushed the telescope-ext branch 2 times, most recently from b6e8f8a to 7644edf Compare June 11, 2025 07:19
@NotAShelf NotAShelf merged commit 0435104 into main Jun 11, 2025
14 checks passed
Copy link

✅ Preview has been deleted successfully!

github-actions bot pushed a commit that referenced this pull request Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add telescope-fzf-native
3 participants