-
-
Notifications
You must be signed in to change notification settings - Fork 136
lsp: fix toggleFormatOnSave #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lsp: fix toggleFormatOnSave #869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just to make sure I understand, the problem RN is that autoformat can't be disabled unless you enable null-ls?
Exactly |
I meant to respond to this earlier, must've gotten to type out a reply. This is good for a merge, and I'll be merging once the CI passeed but it might be nice to ultimately port some of the changes in #768 again. Guessing it is now abandoned. |
✅ Preview has been deleted successfully! |
Sanity Checking
nix fmt
).#nix
(default package).#maximal
.#docs-html
(manual, must build).#docs-linkcheck
(optional, please build if adding links)x86_64-linux
aarch64-linux
x86_64-darwin
aarch64-darwin
Add a 👍 reaction to pull requests you find important.