Skip to content

lsp: fix toggleFormatOnSave #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2025

Conversation

Noah765
Copy link
Contributor

@Noah765 Noah765 commented Apr 30, 2025

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

github-actions bot pushed a commit that referenced this pull request Apr 30, 2025
Copy link

github-actions bot commented Apr 30, 2025

🚀 Live preview deployed from 09f2e1d

View it here:

Debug Information

Triggered by: horriblename

HEAD at: fix-lsp-toggle-format-on-save

Reruns: 817

Copy link
Collaborator

@Soliprem Soliprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just to make sure I understand, the problem RN is that autoformat can't be disabled unless you enable null-ls?

@Noah765
Copy link
Contributor Author

Noah765 commented Apr 30, 2025

LGTM. Just to make sure I understand, the problem RN is that autoformat can't be disabled unless you enable null-ls?

Exactly

github-actions bot pushed a commit that referenced this pull request May 1, 2025
github-actions bot pushed a commit that referenced this pull request May 6, 2025
@NotAShelf
Copy link
Owner

I meant to respond to this earlier, must've gotten to type out a reply.

This is good for a merge, and I'll be merging once the CI passeed but it might be nice to ultimately port some of the changes in #768 again. Guessing it is now abandoned.

github-actions bot pushed a commit that referenced this pull request May 8, 2025
@horriblename horriblename merged commit 09f2e1d into NotAShelf:main May 8, 2025
14 checks passed
Copy link

github-actions bot commented May 8, 2025

✅ Preview has been deleted successfully!

@github-actions github-actions bot deleted the fix-lsp-toggle-format-on-save branch June 15, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants