Skip to content

languages/dart: fix infinite recursion #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Noah765
Copy link
Contributor

@Noah765 Noah765 commented May 5, 2025

The default value of the flutter-tools.enable option conflicted with the lsp.enable definition, which was conditionally defined based on flutter-tools.enable. However, the lsp.enable definition isn't required for flutter-tools' LSP functionality, so it can be removed.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

The default value of the flutter-tools.enable option conflicted with the
lsp.enable definition, which was conditionally defined based on
flutter-tools.enable. However, the lsp.enable definition isn't required
for flutter-tools' LSP functionality, so it can be removed.
github-actions bot pushed a commit that referenced this pull request May 5, 2025
Copy link

github-actions bot commented May 5, 2025

🚀 Live preview deployed from 10a06b3

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: languages-dart-fix-infinite-recursion

Reruns: 802

@NotAShelf NotAShelf merged commit 10a06b3 into NotAShelf:main May 5, 2025
13 of 15 checks passed
@NotAShelf
Copy link
Owner

Thanks :)

Copy link

github-actions bot commented May 5, 2025

✅ Preview has been deleted successfully!

@github-actions github-actions bot deleted the languages-dart-fix-infinite-recursion branch June 15, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants