cmp: use normal priority for default of sources
#884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this change, user configs should be "appended" to default ones instead of overriding them
|
This will force the users to always use |
|
based on how long it took for #839 to be resolved I would disagree, people expect the default value to be extended rather than overwritten alternatively, we could write it down somewhere how listOf/attrsOf options are expected to work |
|
Okay, let's get this fix out of the way and revisit the underlying issue again in the future. I think explicit override is a sensitive matter, and I'd like to discuss it when I have less on my plate. |
|
✅ Preview has been deleted successfully! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #839
After this change, user configs are "appended" to default ones
instead of overriding them