Skip to content

conform: respect vim.lsp.formatOnSave and vim.lsp.mappings.toggleFormatOnSave #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 9, 2025
Merged

conform: respect vim.lsp.formatOnSave and vim.lsp.mappings.toggleFormatOnSave #891

merged 5 commits into from
May 9, 2025

Conversation

horriblename
Copy link
Collaborator

supersedes #768

@horriblename horriblename changed the title Conform format on save fix v2 conform: respect vim.lsp.formatOnSave May 9, 2025
github-actions bot pushed a commit that referenced this pull request May 9, 2025
@actions-user
Deploy PR #891 preview
fed94db
@horriblename horriblename changed the title conform: respect vim.lsp.formatOnSave conform: respect vim.lsp.formatOnSave and vim.lsp.mappings.toggleFormatOnSave May 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2025 •
edited
Loading

🚀 Live preview deployed from 65e1fdd

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: conform-format-on-save-fix-v2

Reruns: 828

NotAShelf
NotAShelf reviewed May 9, 2025
View reviewed changes
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a quick CHANGELOG entry for this? Not a breaking change, but should be communicated more clearly imo.

@horriblename horriblename marked this pull request as draft May 9, 2025 02:10
@horriblename horriblename force-pushed the conform-format-on-save-fix-v2 branch from fb00f60 to 9b505ab Compare May 9, 2025 02:12
@horriblename horriblename force-pushed the conform-format-on-save-fix-v2 branch from 9b505ab to 955f204 Compare May 9, 2025 02:13
@horriblename
Copy link
Collaborator Author

by CHANGELOG you mean release notes right?

@horriblename horriblename marked this pull request as ready for review May 9, 2025 02:17
@NotAShelf
Copy link
Owner

Yes, sorry I'm a little tired. Just a regular entry as we usually add them.

github-actions bot pushed a commit that referenced this pull request May 9, 2025
@actions-user
Deploy PR #891 preview
13f1f75
@NotAShelf NotAShelf merged commit 65e1fdd into NotAShelf:main May 9, 2025
14 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2025

✅ Preview has been deleted successfully!

github-actions bot pushed a commit that referenced this pull request May 9, 2025
@actions-user
Deploy PR #891 preview
0f43058
This was referenced May 13, 2025
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotAShelf NotAShelf NotAShelf approved these changes

@Soliprem Soliprem Awaiting requested review from Soliprem Soliprem is a code owner

Assignees
No one assigned
Labels
topic: documentation topic: modules topic: plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@horriblename @NotAShelf @venkyr77