Skip to content

feat: add treesitter textobjects #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2025
Merged

Conversation

ckoehler
Copy link
Contributor

@ckoehler ckoehler commented May 9, 2025

Not sure if there's a better way to make this load before mini.ai and after TS. Nothing seems to break even if mini.ai is disabled.
I also don't use any default config for the actual plugin, just the objects it provides with my mini.ai user config.

@horriblename
Copy link
Collaborator

I don't understand why mini.ai has to come first? from their README I don't see any dependency between the two?

@horriblename
Copy link
Collaborator

did a bit more reading in their docs, still no mention of needing to load one before the other

@ckoehler
Copy link
Contributor Author

ckoehler commented May 9, 2025

did a bit more reading in their docs, still no mention of needing to load one before the other

See https://github.com/echasnovski/mini.nvim/blob/4e873f36552ac7c15a824f36783c629493f78d0c/doc/mini-ai.txt#L725. If you don't, that query file won't be available and the motions just won't work.

@horriblename
Copy link
Collaborator

the query files will always be there. the only way they could be missing is if you lazy-load TS-textobject, which isn't happening here

github-actions bot pushed a commit that referenced this pull request May 9, 2025
Copy link

github-actions bot commented May 9, 2025

🚀 Live preview deployed from 815ed49

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: ts-textobjects

Reruns: 839

@ckoehler
Copy link
Contributor Author

ckoehler commented May 9, 2025

the query files will always be there. the only way they could be missing is if you lazy-load TS-textobject, which isn't happening here

You're right. I did have it lazy-loading, which required this. But then I changed it. Thanks for pushing back. This makes it easier, too :)

github-actions bot pushed a commit that referenced this pull request May 10, 2025
Copy link
Collaborator

@horriblename horriblename left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NotAShelf NotAShelf merged commit 815ed49 into NotAShelf:main May 11, 2025
14 checks passed
@NotAShelf
Copy link
Owner

Thanks :)

Copy link

✅ Preview has been deleted successfully!

github-actions bot pushed a commit that referenced this pull request May 11, 2025
@github-actions github-actions bot deleted the ts-textobjects branch June 15, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants