-
-
Notifications
You must be signed in to change notification settings - Fork 136
feat: add treesitter textobjects #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't understand why mini.ai has to come first? from their README I don't see any dependency between the two? |
did a bit more reading in their docs, still no mention of needing to load one before the other |
See https://github.com/echasnovski/mini.nvim/blob/4e873f36552ac7c15a824f36783c629493f78d0c/doc/mini-ai.txt#L725. If you don't, that query file won't be available and the motions just won't work. |
the query files will always be there. the only way they could be missing is if you lazy-load TS-textobject, which isn't happening here |
You're right. I did have it lazy-loading, which required this. But then I changed it. Thanks for pushing back. This makes it easier, too :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks :) |
✅ Preview has been deleted successfully! |
Not sure if there's a better way to make this load before mini.ai and after TS. Nothing seems to break even if mini.ai is disabled.
I also don't use any default config for the actual plugin, just the objects it provides with my mini.ai user config.