fix tree-sitter parser packages #921
Conversation
BarryLabs
requested review from
NotAShelf,
horriblename and
Soliprem
as code owners
There was a problem hiding this comment.
Looks good, thank you for the PR.
THere is one missing function that needs to be handled as well, mkGrammarOption found in the extended library will construct package options explicitly for builtGrammars, which means all language modules will continue trying to pull builtGrammars.
|
Please also make sure to add a changelog entry in |
word |
|
i think its good now, appreciate the project :) |
|
Seems the documentation preview was not updated, could you give me a little bit? I need to double-check something, but I'm off my computer right now. I'll be back in an hour or two, and I can give you a final review. |
|
Oops, the CI seems to be failing. If it fails for Nix grammar, I imagine there is an inconsistency in most other language modules as well. |
|
! Ok ill be back |
| @@ -30,7 +30,7 @@ | |||
|
|
|||
| mkGrammarOption = pkgs: grammar: | |||
| mkPackageOption pkgs ["${grammar} treesitter"] { | |||
| default = ["vimPlugins" "nvim-treesitter" "builtGrammars" grammar]; | |||
| default = ["tree-sitter-grammars" grammar]; | |||
There was a problem hiding this comment.
as far as I remember pkgs.tree-sitter-grammars does not work as a nvim plugin, are you sure this works?
There was a problem hiding this comment.
I see, I havent had a moment to take a look since.
|
It builds now except for this norg grammar... We're still referencing pkgs.vimPlugins.nvim-treesitter.norg or whatever it was exactly. |
|
not sure what happened to your git history, but it's including a lot of unrelated changes in 3656f9f in any case, I'm getting this on trying to run |
|
I went crazy with the builder functions and reversed most of them such that it builds my current config but CSS "prettier" and the norgpackage functions are still issues. I was testing it live and I settled here as I didnt want to alter a large portion of the codebase without at least some conversation about it. I am quite stumped how when I hardcode the norg grammar as a default in the "change default?" change, it still expects the previous package...? |
I guess "nvim-treesitter.builtGrammars" got removed and replaced with "nvim-treesitter-parsers" however it didnt have the norg parser I wanted so I replaced the default options with "pkgs.tree-sitter-grammars" to keep it uniform for now.