binds/which-key: allow deregistering binds or groups

[lackac]

options.vim.binds.whichKey.register has type attrsOf (nullOr str), but it actually failed to build with null values. This fixes that and uses null values as a signal to not register a bind or group that was set by one of the plugins.

Sanity Checking

• I have updated the changelog as per my changes
• I have tested, and self-reviewed my code
• My changes fit guidelines found in hacking nvf
• Style and consistency
  • I ran Alejandra to format my code (nix fmt)
  • My code conforms to the editorconfig configuration of the project
  • My changes are consistent with the rest of the codebase
• If new changes are particularly complex:
  • My code includes comments in particularly complex areas
  • I have added a section in the manual
  • (For breaking changes) I have included a migration guide
• Package(s) built:
  • .#nix (default package)
  • .#maximal
  • .#docs-html (manual, must build)
  • .#docs-linkcheck (optional, please build if adding links)
• Tested on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin

---

Add a 👍 reaction to pull requests you find important.

[github-actions]

🚀 Live preview deployed from c4d8027

View it here:

Debug Information

Triggered by: lackac

HEAD at: which-key-deregister

Reruns: 1048

[horriblename]

this doesn't "deregister" the group does it? just makes it a group with no description

[lackac]

this doesn't "deregister" the group does it? just makes it a group with no description

no, it does. It uses lib.lists.optional to omit those keys that are set to null from the actual configuration that which-key receives. There are a number of keys that are registered in the nvf config (e.g. for trouble) and they use pushDownDefault so can be overridden by setting them null by the user. The change in this PR is necessary to make that possible.

[horriblename]

LGTM Thanks!