assistant/supermaven-nvim: init

[justDeeevin]

supermaven-nvim's README claims nvim-cmp integration is as simple as adding "supermaven" to the sources list, so I felt it unnecessary to add a separate option for that here. Let me know if that should be changed.

Also, this is my first time contributing here, so sorry if there's anything that doesn't fit standards. I referred to the other assistant options when writing this.

[github-actions]

🚀 Live preview deployed from c4d8027

View it here:

Debug Information

Triggered by: justDeeevin

HEAD at: add-supermaven

Reruns: 1049

[Soliprem]

off the bat, that change will get it to build. On the rest, I'm unfamiliar with the workflow for Supermaven, but on the nix side (besides my reviews), things LGTM.

I recommend you use the checklist, regarding style and testing, that comes as the templates for new PRs :). It's great for first-time contributors to dodge "obvious" reviews and for long-time contributors as an actual checklist of things to remember (it's also just a bunch of things we don't have to wonder if you did, which makes reviewing easier).

Thanks for the work <3

p.s. It looks like it works correctly, but I noticed it downloading a binary? Unsure of where that's being stored

[NotAShelf]

Thank you for the good work. I'm leaving two comments for the sake of consistency with the project styles. Soliprem's comments also apply.

Lastly, please add a changelog entry before we can merge this.

[justDeeevin]

I recommend you use the checklist

When I created the PR it didn't pre-fill the description with the template. Don't know why that happened! Thanks for your feedback in the face of this.

Also, apologies for not properly testing, I should have known better. I need to stop making midnight PRs🫠

[justDeeevin]

I changed it to supermaven-nvim as requested. However, I still think supermaven would make more sense. The option for copilot is just assistant.copilot even though the plugin itself is called copilot-lua. Is there a particular rationale for this I'm not seeing?

[justDeeevin]

p.s. It looks like it works correctly, but I noticed it downloading a binary? Unsure of where that's being stored

Reading the source code, it looks like this gets put in $XDG_DATA_HOME/supermaven (or $HOME/.supermaven if XDG_DATA_HOME is unset).

[NotAShelf]

I changed it to supermaven-nvim as requested. However, I still think supermaven would make more sense. The option for copilot is just assistant.copilot even though the plugin itself is called copilot-lua. Is there a particular rationale for this I'm not seeing?

Sorry for the late response. This is a relatively new "convention" that we've started applying in light of some future refactor plans. There are plugins that do not adhere to the convention yet, as they have been added before we even discussed such a naming decision. It'll be easier for everyone if you name the options after the plugins :)

[lackac]

When I created the PR it didn't pre-fill the description with the template. Don't know why that happened! Thanks for your feedback in the face of this.

I also noticed this. I'm always adding &template=pull_request_template.md to the end of the URL when creating a pull request. But if we want people to use the checklist, it should be automatic. I think the file could be moved to .github/pull_request_template.md if a single template is sufficient and that will make it apply automatically.

[NotAShelf]

I'm quite positive that the pull request template is active by default. Unless, of course, GH has changed how it functions. Last I've checked the template is "prompted" by default, and it's usable in CLI tools like gh. I'll look into it on monday.

[justDeeevin]

What's left to do here?

[NotAShelf]

can be merged with @Soliprem's approval.

[Soliprem]

LGTM

[justDeeevin]

CI was failing due to an oversight when renaming from supermaven to supermaven-nvim. fix pushed. Also force-pushed with rebase to resolve conflict.

[NotAShelf]

I'm sorry I've caused a merge conflict again, if you could resolve it I can merge this right away

[justDeeevin]

So strange that that should cause a conflict.

Done!