Skip to content

spellcheck: restore configuration for vim-dirtytalk #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lackac
Copy link
Contributor

@lackac lackac commented Jul 5, 2025

I was looking for a way to reenable the vim-dirtytalk plugin as it looks like it was removed at some point. I changed the target of the configuration from pluginRC to luaConfigRC as it needs to be run after the spellcheck section which is in the latter. This solution works, but one needs to run :DirtytalkUpdate at first use still.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

Copy link

github-actions bot commented Jul 5, 2025

🚀 Live preview deployed from 5d607f3

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: spellcheck-restore-programming-wordlist

Reruns: 1045

Soliprem
Soliprem previously approved these changes Jul 6, 2025
Copy link
Collaborator

@Soliprem Soliprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NotAShelf
Copy link
Owner

The real reason I've held off vim-dirtytalk is that I do not like the plugin. It's Vimscript, abandoned, and the grammar fetching is totally wack. I'm going to rewrite it in Lua, and we can maybe give it an alternative fetching method for spellwords :)

@lackac
Copy link
Contributor Author

lackac commented Jul 7, 2025

The real reason I've held off vim-dirtytalk is that I do not like the plugin. It's Vimscript, abandoned, and the grammar fetching is totally wack. I'm going to rewrite it in Lua, and we can maybe give it an alternative fetching method for spellwords :)

Fair enough. Do you think this change could be merged in the meantime? It just makes a documented option working again… It's not a crucial thing though, so feel free to close the PR if you'd rather leave it as it is.

@NotAShelf
Copy link
Owner

The real reason I've held off vim-dirtytalk is that I do not like the plugin. It's Vimscript, abandoned, and the grammar fetching is totally wack. I'm going to rewrite it in Lua, and we can maybe give it an alternative fetching method for spellwords :)

Fair enough. Do you think this change could be merged in the meantime? It just makes a documented option working again… It's not a crucial thing though, so feel free to close the PR if you'd rather leave it as it is.

Yes, of course. If you could just fix the merge conflict I'll go ahead and merge this.

github-actions bot pushed a commit that referenced this pull request Jul 8, 2025
@NotAShelf NotAShelf merged commit 5d607f3 into NotAShelf:main Jul 8, 2025
14 checks passed
Copy link

github-actions bot commented Jul 8, 2025

✅ Preview has been deleted successfully!

github-actions bot pushed a commit that referenced this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants