-
-
Notifications
You must be signed in to change notification settings - Fork 134
spellcheck: restore configuration for vim-dirtytalk #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spellcheck: restore configuration for vim-dirtytalk #991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The real reason I've held off vim-dirtytalk is that I do not like the plugin. It's Vimscript, abandoned, and the grammar fetching is totally wack. I'm going to rewrite it in Lua, and we can maybe give it an alternative fetching method for spellwords :) |
Fair enough. Do you think this change could be merged in the meantime? It just makes a documented option working again… It's not a crucial thing though, so feel free to close the PR if you'd rather leave it as it is. |
Yes, of course. If you could just fix the merge conflict I'll go ahead and merge this. |
✅ Preview has been deleted successfully! |
I was looking for a way to reenable the vim-dirtytalk plugin as it looks like it was removed at some point. I changed the target of the configuration from
pluginRC
toluaConfigRC
as it needs to be run after thespellcheck
section which is in the latter. This solution works, but one needs to run:DirtytalkUpdate
at first use still.Sanity Checking
nix fmt
).#nix
(default package).#maximal
.#docs-html
(manual, must build).#docs-linkcheck
(optional, please build if adding links)x86_64-linux
aarch64-linux
x86_64-darwin
aarch64-darwin
Add a 👍 reaction to pull requests you find important.