Skip to content

Limit to footnote link itself #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RakoGames
Copy link

Specified only the link of the footnote itself; so the selector doesn't apply on other a elements in the footnote like collapsibles

Also the :is(.footnotes-footer, .bibitems) tag specifies the child a[href*=javascript] which is not beneficial to bibitems since wikidot doesn't add a link to these anyways and are only added to footnotes (unless a user add one inside the contents of one, in which case we do not want to target nor affect); so I changed it to specify the child .footnote-footer > a[href*=javascript] hence only affecting the footnotes only

should not cause any issues with my testing

Specified only the link of the footnote itself; so the selector doesn't apply on other a elements in the footnote like collapsibles
@emmiegit emmiegit changed the title Update elements.css Limit to footnote link itself May 12, 2025
@SYwaves
Copy link
Contributor

SYwaves commented May 13, 2025

While this does exclude collapsible links from being affected, this does not completely limit the range of a from being targeted in footnote-footer, and would still be affected by this bug: #245

A more comprehensive selector (that also won't raise specificity) would be something like:
& :where(.footnote-footer) > a:first-child::before
or
& :where(.footnote-footer) > a[onclick*="footnoteref"]::before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants