Add SDKAnalysisLevel and UsingMicrosoftNETSdk to packageSpec#5833
Merged
Nigusu-Allehu merged 62 commits intodevfrom Jul 12, 2024
Merged
Add SDKAnalysisLevel and UsingMicrosoftNETSdk to packageSpec#5833Nigusu-Allehu merged 62 commits intodevfrom
Nigusu-Allehu merged 62 commits intodevfrom
Conversation
nkolev92
reviewed
May 31, 2024
zivkan
reviewed
Jun 4, 2024
kartheekp-ms
reviewed
Jun 7, 2024
578030c to
3594a62
Compare
Nigusu-Allehu
commented
Jun 7, 2024
Nigusu-Allehu
commented
Jun 7, 2024
Nigusu-Allehu
commented
Jun 7, 2024
zivkan
reviewed
Jun 13, 2024
zivkan
reviewed
Jun 13, 2024
Nigusu-Allehu
commented
Jun 13, 2024
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/MSBuildRestoreUtility.cs
Outdated
Show resolved
Hide resolved
zivkan
reviewed
Jun 13, 2024
zivkan
reviewed
Jun 14, 2024
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/MSBuildRestoreUtility.cs
Outdated
Show resolved
Hide resolved
zivkan
reviewed
Jun 14, 2024
zivkan
reviewed
Jun 14, 2024
jeffkl
reviewed
Jul 10, 2024
src/NuGet.Clients/NuGet.SolutionRestoreManager/VSNominationUtilities.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Build.Tasks.Console/MSBuildStaticGraphRestore.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/MSBuildRestoreUtility.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/MSBuildRestoreUtility.cs
Show resolved
Hide resolved
...Get.PackageManagement.VisualStudio.Test/ProjectSystems/LegacyPackageReferenceProjectTests.cs
Outdated
Show resolved
Hide resolved
...Get.PackageManagement.VisualStudio.Test/ProjectSystems/LegacyPackageReferenceProjectTests.cs
Outdated
Show resolved
Hide resolved
jeffkl
previously approved these changes
Jul 10, 2024
nkolev92
reviewed
Jul 11, 2024
src/NuGet.Clients/NuGet.SolutionRestoreManager/VSNominationUtilities.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/MSBuildRestoreUtility.cs
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/MSBuildRestoreUtility.cs
Outdated
Show resolved
Hide resolved
...Get.PackageManagement.VisualStudio.Test/ProjectSystems/LegacyPackageReferenceProjectTests.cs
Outdated
Show resolved
Hide resolved
jeffkl
previously approved these changes
Jul 11, 2024
nkolev92
previously approved these changes
Jul 11, 2024
nkolev92
reviewed
Jul 11, 2024
zivkan
previously approved these changes
Jul 11, 2024
Member
zivkan
left a comment
There was a problem hiding this comment.
I still think there's scope for improvement, but nothing blocking.
zivkan
approved these changes
Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13309
Regression? Last working version:
Description
SDKAnalysisLevelvalue inMicrosoft.NETCoreSdk.BundledVersions.propswhich is consumed early by msbuild. This is then consumed during restore.SdkAnalysisLevelandUsingMicrosoftNetSdkand have them ready in package spec of a project.dotnet / msbuild
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/MSBuildRestoreUtility.csto get the dgspec content, updateMsbuildRestoreUtilityto getSdkAnalysisLevelandUsingMicrosoftNETSdkproperties.nuget.exe
SDKAnalysisLevelandUsingMicrosoftNETSdkwhich will then be consumed by nuget.exe restore command and then passed to the restore runner similar to dotnet /msbuild restore.the dgspec file would looks as follows
VS
SdkAnalysisLevelandUsingMicrosoftNETSdkvalues and add them to the corresponding projectpackageSpecPR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation
https://github.com/Create a documentation for HTTP errors introduced for insecure sources Home#13603