AOT compatible: enable in NuGet.Protocol #7193
Merged
Nigusu-Allehu merged 10 commits intodevfrom Mar 16, 2026
Merged
Conversation
Nigusu-Allehu
force-pushed
the
dev-nyenework-nuget.protocol-AOT
branch
from
b293b21 to
edd963d
Compare
Nigusu-Allehu
changed the title
zivkan
reviewed
Mar 9, 2026
src/NuGet.Core/NuGet.Protocol/PublicAPI/net472/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
Nigusu-Allehu
changed the title
jeffkl
previously approved these changes
Mar 10, 2026
nkolev92
reviewed
Mar 12, 2026
Nigusu-Allehu
force-pushed
the
dev-nyenework-nuget.protocol-AOT
branch
from
9c5cb50 to
0694817
Compare
nkolev92
approved these changes
Mar 13, 2026
jeffkl
approved these changes
Mar 16, 2026
This was referenced Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14792
Related: NuGet/Home#14408
Description
Enables AOT compatibility in NuGet.Protocol
Types that need string deduplication now
implement
CacheStrings(MetadataReferenceCache cache)directly instead of relying on runtime property discoveryChanges
PackageSearchMetadataandClonedPackageSearchMetadataimplementCacheStringmethod for caching.metadataCache.GetObject()call inLocalPackageMetadataResource(was a no-opLocalPackageSearchMetadatahas no settable string properties)GetObject<T>()is retained as a no-op for API compatibility. String caching is now done directly by the two classes above.PR Checklist