Sourcery refactored CPython37 branch#1
Closed
sourcery-ai[bot] wants to merge 1 commit intoCPython37from
Closed
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| active = search_mode.consider(dirname, filename) | ||
|
|
||
| if active: | ||
| if active := search_mode.consider(dirname, filename): |
Author
There was a problem hiding this comment.
Function checkDir refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-89
to
+99
| if line.find("set(attr for attr in dir(g) if not attr.startswith('__')) >= expected") != -1: | ||
| return True | ||
| elif line.find("isinstance(g, types.GeneratorType)") != -1: | ||
| return True | ||
| else: | ||
| return False | ||
| return ( | ||
| line.find( | ||
| "set(attr for attr in dir(g) if not attr.startswith('__')) >= expected" | ||
| ) | ||
| != -1 | ||
| or line.find( | ||
| "set(attr for attr in dir(g) if not attr.startswith('__')) >= expected" | ||
| ) | ||
| == -1 | ||
| and line.find("isinstance(g, types.GeneratorType)") != -1 | ||
| ) |
Author
There was a problem hiding this comment.
Function filter_genexps refactored with the following changes:
- Simplify boolean if expression (
boolean-if-exp-identity) - Merge duplicate blocks in conditional (
merge-duplicate-blocks) - Replace if statement with if expression (
assign-if-exp)
|
|
||
| def setx(self, x): | ||
| if x < 0: x = 0 | ||
| x = max(x, 0) |
Author
There was a problem hiding this comment.
Function C.setx refactored with the following changes:
- Replace comparison with min/max call (
min-max-identity)
| return self.__x | ||
| def setx(self, x): | ||
| if x < 0: x = 0 | ||
| x = max(x, 0) |
Author
There was a problem hiding this comment.
Function C.setx refactored with the following changes:
- Replace comparison with min/max call (
min-max-identity)
| try: | ||
| def firstn(g, n): | ||
| return [next(g) for i in range(n)] | ||
| return [next(g) for _ in range(n)] |
Author
There was a problem hiding this comment.
Function firstn refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore)
Comment on lines
-863
to
+853
| for x in self.parent.generator: | ||
| yield x | ||
| yield from self.parent.generator |
Author
There was a problem hiding this comment.
Function disjointSet.generate refactored with the following changes:
- Replace yield inside for loop with yield from (
yield-from)
Comment on lines
-925
to
+918
| try: | ||
| 1//0 | ||
| except ZeroDivisionError: | ||
| yield 666 | ||
| except: | ||
| pass | ||
| 1//0 | ||
| except ZeroDivisionError: | ||
| yield 666 | ||
| except: | ||
| pass |
Author
There was a problem hiding this comment.
Function f refactored with the following changes:
- Merge nested try-statement into a single try (
flatten-nested-try)
Comment on lines
-979
to
+967
| if 0: | ||
| yield | ||
| pass |
Author
There was a problem hiding this comment.
Function f refactored with the following changes:
- Remove redundant conditional (
remove-redundant-if)
Comment on lines
-996
to
+983
| if 0: | ||
| yield 1 | ||
| pass |
Author
There was a problem hiding this comment.
Function f refactored with the following changes:
- Remove redundant conditional (
remove-redundant-if)
Comment on lines
-1013
to
+999
| if "": | ||
| yield None | ||
| pass |
Author
There was a problem hiding this comment.
Function f refactored with the following changes:
- Remove redundant conditional (
remove-redundant-if)
Comment on lines
-1031
to
-1049
| try: | ||
| if x==4: | ||
| pass | ||
| elif 0: | ||
| try: | ||
| 1//0 | ||
| except SyntaxError: | ||
| pass | ||
| else: | ||
| if 0: | ||
| while 12: | ||
| x += 1 | ||
| yield 2 # don't blink | ||
| f(a, b, c, d, e) | ||
| else: | ||
| pass | ||
| except: | ||
| x = 1 | ||
| return |
Author
There was a problem hiding this comment.
Function f refactored with the following changes:
- Remove unreachable code (
remove-unreachable-code) - Remove redundant conditional (
remove-redundant-if)
This removes the following comments ( why? ):
# don't blink
Comment on lines
-1104
to
+1070
| if 0: | ||
| return | ||
| if 0: | ||
| yield 2 | ||
| pass |
Author
There was a problem hiding this comment.
Function f refactored with the following changes:
- Remove redundant conditional (
remove-redundant-if)
| def f(): | ||
| yield 1 | ||
| return | ||
| yield 2 # never reached |
Author
There was a problem hiding this comment.
Function f refactored with the following changes:
- Remove unreachable code (
remove-unreachable-code)
This removes the following comments ( why? ):
# never reached
Comment on lines
-1415
to
+1377
| for i in range(n): | ||
| yield i | ||
| yield from range(n) |
Author
There was a problem hiding this comment.
Function yrange refactored with the following changes:
- Replace yield inside for loop with yield from (
yield-from)
Comment on lines
-1454
to
+1415
| for i in yrange(n): | ||
| yield i | ||
| yield from yrange(n) |
Author
There was a problem hiding this comment.
Function zrange refactored with the following changes:
- Replace yield inside for loop with yield from (
yield-from)
Comment on lines
-95
to
+94
| for x in {i for i in range(n)}: | ||
| yield x | ||
| yield from set(range(n)) |
Author
There was a problem hiding this comment.
Function grange refactored with the following changes:
- Replace yield inside for loop with yield from (
yield-from) - Replace identity comprehension with call to collection constructor (
identity-comprehension)
Comment on lines
-245
to
+243
| items = {(lambda: y) for i in range(5)} | ||
| items = {lambda: y for _ in range(5)} |
Author
There was a problem hiding this comment.
Function test_func refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore)
| # failures because some calls block a bit | ||
| # longer than expected | ||
| if CHECK_TIMINGS: | ||
| if CHECK_TIMINGS := False: |
Author
There was a problem hiding this comment.
Lines 94-98 refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
This removes the following comments ( why? ):
# longer than expected
# failures because some calls block a bit
# making true makes tests take a lot longer
# and can sometimes cause some non-serious
Comment on lines
-359
to
+356
| exitcode = self._kill_process(multiprocessing.Process.terminate) | ||
| if os.name != 'nt': | ||
| exitcode = self._kill_process(multiprocessing.Process.terminate) |
Author
There was a problem hiding this comment.
Function _TestProcess.test_terminate refactored with the following changes:
- Move assignments closer to their usage (
move-assign)
Comment on lines
-364
to
+361
| exitcode = self._kill_process(multiprocessing.Process.kill) | ||
| if os.name != 'nt': | ||
| exitcode = self._kill_process(multiprocessing.Process.kill) |
Author
There was a problem hiding this comment.
Function _TestProcess.test_kill refactored with the following changes:
- Move assignments closer to their usage (
move-assign)
Author
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.06%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Member
|
Not working on this code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
CPython37refactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
CPython37branch, then run:Help us improve this pull request!