fix(flate encoder): do not mark internal state as flushed if we ran out of buffer space #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut of output buffer space
|
This bug was encountered in chatmail/core#6656 when uploading a large message over IMAP with IMAP COMPRESS extension. Writer pushed the message into encoder, but then only one output buffer makes it to the server after flush() and subsequent flush calls do nothing. |
NobodyXu
requested changes
Mar 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
link2xt
added a commit
to chatmail/core
that referenced
this pull request
Mar 15, 2025
…stuck async-compression 0.4.21 fixes a bug in the encoder where it did not flush all the internal state sometimes, resulting in IMAP APPEND command timing out waiting for response when uploading large sync messages. See <Nullus157/async-compression#333> for details.
link2xt
added a commit
to chatmail/core
that referenced
this pull request
Mar 15, 2025
…stuck async-compression 0.4.21 fixes a bug in the encoder where it did not flush all the internal state sometimes, resulting in IMAP APPEND command timing out waiting for response when uploading large sync messages. See <Nullus157/async-compression#333> for details.
|
@link2xt thanks a lot for diving into that sea of code and delendencies 🤿 for finding and and for fixing the bug ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be data remaining in the internal state of the encoder.
Without the fix on a second call to flush() when the caller makes space in the output buffer we will write nothing into the buffer.