Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update foodon.md #2609

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Update foodon.md #2609

merged 8 commits into from
Aug 21, 2024

Conversation

ddooley
Copy link
Contributor

@ddooley ddooley commented Jun 11, 2024

Updating usages

Updating usages
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ddooley for updating the impressive usages for FOODON!

Unfortunately, so we dont open the floodgates to the wild west, we require verifiable usages. For example:

A link to a FOODON term on a site is a good proof.

We have had huge debates whether scientific papers count as proof and I forgot were we stand on this, but I guess we said ok.

@ddooley
Copy link
Contributor Author

ddooley commented Jun 11, 2024

I was trying to fulfill usages references for FoodOn, but I can't really see what's wrong in yaml file from error report of first step. Also I don't know how to edit what I submitted there from the OBO Foundry "Edit" yaml option which leads to: https://github.com/OBOFoundry/OBOFoundry.github.io/edit/master/ontology/foodon.md

@matentzn
Copy link
Contributor

You can

  1. https://github.com/OBOFoundry/OBOFoundry.github.io/pull/2609/files click here
  2. Hit the edit button:

image

To edit the yaml file in this PR.

Dont worry about QC, for now, I can help you fix it. You have to run "tox -e lint" on the command line, but @jsstevenson will write an action at some point to do this automatically. In the meantime, I can do it for you.

@ddooley
Copy link
Contributor Author

ddooley commented Jul 19, 2024

Ok thanks for your help. I've updated the pull request to include links to specific entries showing FoodOn IDs.

ontology/foodon.md Show resolved Hide resolved
ontology/foodon.md Outdated Show resolved Hide resolved
@deepakunni3
Copy link
Member

@ddooley Please see and address the above comments.

I updated the usage examples to better fit the formatting described in https://obofoundry.org/principles/fp-009-users.html (See the 'Implementation' and/or 'Examples' section). I also fixed the linting issue you were seeing earlier.

@ddooley
Copy link
Contributor Author

ddooley commented Aug 20, 2024

@deepakunni3 I think everything is resolved now! Thanks for checking it out in detail.

@deepakunni3
Copy link
Member

@ddooley Thank you! Looks good to me :)

@deepakunni3 deepakunni3 merged commit 6bc050f into master Aug 21, 2024
5 checks passed
@deepakunni3 deepakunni3 deleted the ddooley-patch-1 branch August 21, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants