[14.0][backport] account: Allow skipping bank account creation on reconciliation #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces system parameter to skip the creation of bank account in the reconciliation of bank statements. The issue it can solve happens when 2 different commercial entities use the same paying partner (ie a partner that is not a subcontact) to pay their invoices. When an invoice is paid by the paying partner, Odoo will store the account number that was used for the transfer on account.bank.statement.line. When this statement line is reconciled with an invoice, if the bank account was not stored on the partner previously, a res.partner.bank will be created automatically. When another payment is coming from the same bank account, Odoo will then select the partner linked to the bank account that it did store previously, even if the payment was for an invoice linked to another partner, and it will not propose the proper invoice in the reconciliation widget, even if it uses an exact match on the payment reference number. Having a parameter allowing to skip creation of the bank account in Odoo will allow the reconciliation to be based striclty on the reference number. closes odoo#168029 Signed-off-by: Laurent Smet (las) <[email protected]>
grindtildeath
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Backport of the fix in account module that introduces a system variable to skip creation of bank accounts in the reconciliation of bank statements. See original PR for more information: odoo#168029
Current behavior before PR:
In cases where multiple partners (Partner A, Partner B) use the same bank account due to a third-party payment handler, bank account is assigned for a Partner A when first invoice is reconciled. Subsequent invoices with the same bank account are reconciled automatically to Partner A using this stored bank account, and Partner B not proposed by the reconciliation widget
Desired behavior after PR is merged:
Allow to avoid storing bank account and having wrong invoices proposed by the reconciliation widget
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr