[9.0][IMP] product: migrate simple purchase pricelists #2736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbrunn
changed the title
astirpe
suggested changes
Aug 6, 2021
| select | ||
| partner_id, min_quantity, currency_id, p2i.date_start, p2i.date_end, | ||
| p2i.company_id, p2i.product_id, p2i.product_tmpl_id, | ||
| coalesce(pt1.%(field_name)s, pt2.%(field_name)s) * |
There was a problem hiding this comment.
In case %(field_name)s is standard_price (and this should be the only case IMO) we should take in consideration that in V9 standard_price is a property of product.product (and not of product.template).
To retrieve the proper product prices this should work:
select
split_part(res_id, ',', 2)::int product_id,
value_float amount,
company_id
from ir_property
where
fields_id in (
select res_id from ir_model_data
where name like 'field_product_product_standard_price'
) and res_id is not null and value_float is not nullThere was a problem hiding this comment.
thanks for your input, the moving of the property to product.product happens indeed before this happens. Now this should be finr
hbrunn
force-pushed
the
9.0-product_purchase_pricelists
branch
2 times, most recently
from
52f9244 to
a0dd0d5
Compare
hbrunn
force-pushed
the
9.0-product_purchase_pricelists
branch
from
e4c6cbc to
61a3bc5
Compare
|
@hbrunn given that we had something of a flood of vendor prices after the migration, there may be room for improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr