Conversation
|
/ocabot migration delivery |
MiquelRForgeFlow
force-pushed
the
17.0_ou_delivery
branch
from
8fe68bb to
a1fa4e7
Compare
legalsylvain
added
Dependency OK
Blocked by dependency
and removed
Dependency OK
labels
legalsylvain
added
Dependency OK
Blocked by dependency
and removed
Blocked by dependency
Dependency OK
labels
legalsylvain
added
Dependency OK
Blocked by dependency
and removed
Blocked by dependency
Dependency OK
labels
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 313264a. Thanks a lot for contributing to OCA. ❤️ |
carlos-lopez-tecnativa
left a comment
carlos-lopez-tecnativa
left a comment
There was a problem hiding this comment.
@MiquelRForgeFlow @pedrobaeza
Tested and working, but I left a few comments. I think it can be improved. Please let me know if I can create a new PR to finish the migration if my comments are applied.
TT52315
| DEL ir.ui.view: delivery.choose_delivery_package_view_form | ||
| DEL ir.ui.view: delivery.delivery_stock_report_delivery_no_package_section_line | ||
| DEL ir.ui.view: delivery.delivery_tracking_url_warning_form | ||
| DEL ir.ui.view: delivery.label_package_template_view_delivery | ||
| DEL ir.ui.view: delivery.product_template_hs_code | ||
| DEL ir.ui.view: delivery.report_delivery_document2 | ||
| DEL ir.ui.view: delivery.report_package_barcode_delivery | ||
| DEL ir.ui.view: delivery.report_package_barcode_small_delivery | ||
| DEL ir.ui.view: delivery.report_shipping2 |
There was a problem hiding this comment.
I noticed that these records were simply moved from delivery to stock_delivery. Why not rename the xml_id instead?
| DEL ir.ui.view: delivery.stock_move_line_view_search_delivery | ||
| DEL ir.ui.view: delivery.stock_package_type_form_delivery | ||
| DEL ir.ui.view: delivery.stock_package_type_tree_delivery | ||
| DEL ir.ui.view: delivery.stock_report_delivery_aggregated_move_lines_inherit_delivery | ||
| DEL ir.ui.view: delivery.stock_report_delivery_has_serial_move_line_inherit_delivery | ||
| DEL ir.ui.view: delivery.stock_report_delivery_package_section_line_inherit_delivery | ||
| DEL ir.ui.view: delivery.view_move_line_tree_detailed_delivery | ||
| DEL ir.ui.view: delivery.view_picking_type_form_delivery | ||
| DEL ir.ui.view: delivery.view_picking_withcarrier_out_form | ||
| DEL ir.ui.view: delivery.view_picking_withweight_internal_move_form | ||
| DEL ir.ui.view: delivery.view_quant_package_weight_form | ||
| DEL ir.ui.view: delivery.view_stock_rule_form_delivery | ||
| DEL ir.ui.view: delivery.vpicktree_view_tree |
There was a problem hiding this comment.
The same case applies here. The only change is that sale_order_portal_content_inherit_sale_stock_inherit_website_sale_delivery was renamed to sale_order_portal_content_inherit_sale_stock_inherit_website_sale, but the content remains the same.
| delivery / delivery.carrier / invoice_policy (selection) : selection_keys is now '['estimated']' ('['estimated', 'real']') | ||
| # NOTHING TO DO | ||
|
|
||
| delivery / sale.order / shipping_weight (float) : NEW hasdefault: compute |
There was a problem hiding this comment.
sale.order can be considered a transactional record with many entries, so I think this new field should be filled using SQL instead of the ORM. Is there any specific reason to keep the ORM computation?
| <field name="name">Standard delivery</field> | ||
| </record> | ||
| <record id="product_product_delivery" model="product.product"> |
There was a problem hiding this comment.
The product name and delivery name are fields that are translated. Why not delete translations using the delete_translations function from openupgradelib?
I got a similar comment from @pedrobaeza on #4771 (comment)
5 participants
Supersedes #4637.