Skip to content

[13.0][FIX] account: avoid infinite loop when searching for child taxes #4884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 13.0
Choose a base branch
from

Conversation

TelmoSuarez
Copy link

Control infinite recursive loop while searching for child taxes. This happens when a child's child is it's parent (A->B->A)

@legalsylvain
Copy link
Contributor

Hi @TelmoSuarez

his happens when a child's child is it's parent (A->B->A)

This configuration looks weird. could you mention wich localization has such circular settings ?

thanks !

@TelmoSuarez
Copy link
Author

Hi @legalsylvain.

I found this issue in l10_es. In my case i'm migrating a client from 11.0 to 16.0, that had been previously migrated from 8.0.
I'm not 100% sure if this is specific to my case or is a more general issue, will test with clean db.
In l10n_es's migration to 13.0 found this query that would "fix" this issue, but due to migration order(account -> l10n_es) it gets stuck in account's query.

@TelmoSuarez TelmoSuarez force-pushed the 13.0-fix-account_migration branch from 611e5a9 to fb2bd00 Compare March 27, 2025 08:56
@legalsylvain
Copy link
Contributor

@MiquelRForgeFlow / @pedrobaeza : any point of view regarding recursive taxes ?

@MiquelRForgeFlow MiquelRForgeFlow added this to the 13.0 milestone Mar 27, 2025
@TelmoSuarez TelmoSuarez changed the title [FIX] account: avoid infinite loop when searching for child taxes [13.0][FIX] account: avoid infinite loop when searching for child taxes Mar 27, 2025
@pedrobaeza
Copy link
Member

Well, the error is due to a previous incorrect data handling, so not sure if we should handle here. Anyway, if the SQLs cost is simple and effective, we can do it. I'm not qualified right now to say if the change on the SQLs are OK or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants